Thom Mahoney thommahoney

thommahoney commented on issue pry/pry#1296
@thommahoney

command_prefix is also set by rake-remote_task if you are using that gem. See seattlerb/rake-remote_task#24 for more information.

thommahoney closed pull request fastly/fastly-rails#32
@thommahoney
Allow Fastly headers and purges to be disabled globally
thommahoney commented on pull request fastly/fastly-rails#32
@thommahoney

Closing in favor of #39

thommahoney opened pull request fastly/fastly-rails#41
@thommahoney
add link to docs for service ids and api keys
1 commit with 2 additions and 0 deletions
thommahoney deleted branch rename-service-id at fastly/fastly-rails
@thommahoney
thommahoney merged pull request fastly/fastly-rails#40
@thommahoney
Rename service_id to fastly_service_identifier
10 commits with 36 additions and 25 deletions
@thommahoney
Incompatibilities with "service_id" as a column name
thommahoney commented on pull request fastly/fastly-rails#40
@thommahoney

I think we should be testing that Book#service_id doesn't conflict with the gem any longer. A test that simply asserts that the value of service_id

thommahoney commented on pull request fastly/fastly-rails#39
@thommahoney

@gingermusketeer Thanks for your PR! I've made a few comments asking for some tests. Looks good otherwise.

thommahoney commented on pull request fastly/fastly-rails#39
@thommahoney

It would be best to also test that the method does not execute client.purge_by_key when purging_enabled is false.

thommahoney commented on pull request fastly/fastly-rails#39
@thommahoney

These lines should be unnecessary as true is the default.

thommahoney commented on pull request fastly/fastly-rails#39
@thommahoney

This is the default behavior. Could you also add tests for the negative? (same for cache_headers_enabled please)

@thommahoney

We should have talked to @drbrain! Thanks @copiousfreetime and sorry for wasting your time.

@thommahoney

Unfortunately I don't know enough about how c extensions are configured and compiled to be of any help. I found a bug that was fixed two years ago …

@thommahoney

This can be reproduced using the command `gem install hitimes --path '/some path/name'

@thommahoney
@thommahoney
@thommahoney