New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable on mobile #2

Open
thompsonemerson opened this Issue Oct 21, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@thompsonemerson
Owner

thompsonemerson commented Oct 21, 2017

No description provided.

@carlosnufe

This comment has been minimized.

Show comment
Hide comment
@carlosnufe

carlosnufe commented Oct 22, 2017

Hi @thompsonemerson,

Here we go, PR

@thompsonemerson

This comment has been minimized.

Show comment
Hide comment
@thompsonemerson

thompsonemerson Oct 22, 2017

Owner

Hi @carlosnufe, thanks for the contribution, but the precise verification is in the core

Owner

thompsonemerson commented Oct 22, 2017

Hi @carlosnufe, thanks for the contribution, but the precise verification is in the core

@carlosnufe

This comment has been minimized.

Show comment
Hide comment
@carlosnufe

carlosnufe Oct 23, 2017

Hi @thompsonemerson, there's not template or html to modify besides which is in demo folder.

What do you mean with core? There's another repo? If there is, this issue should be opened there.
If you are suggesting to modify cardmove.js isn't a good idea. This kind of verifications must go in another place.

Can we move on?

carlosnufe commented Oct 23, 2017

Hi @thompsonemerson, there's not template or html to modify besides which is in demo folder.

What do you mean with core? There's another repo? If there is, this issue should be opened there.
If you are suggesting to modify cardmove.js isn't a good idea. This kind of verifications must go in another place.

Can we move on?

@thompsonemerson

This comment has been minimized.

Show comment
Hide comment
@thompsonemerson

thompsonemerson Oct 24, 2017

Owner

Yes, on cardmove.js.
the application needs to know it behaves in the environment, I can not leave that verification to the user.

Owner

thompsonemerson commented Oct 24, 2017

Yes, on cardmove.js.
the application needs to know it behaves in the environment, I can not leave that verification to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment