New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2.0 support #67

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@stasfilin
Contributor

stasfilin commented Jan 16, 2018

Resolve #65

Add Django 2.0 support
Signed-off-by: Stanislav Filin <stasfilinmusic@gmail.com>
@thornomad

This comment has been minimized.

Owner

thornomad commented Jan 19, 2018

Thank you that is awesome! Appreciate your hard work. I need to check this out and run it on my local machine because the Travis tests did not pass. Looks like there are some flake8 errors and I need to install 3.6 as well.

Hopefully can sort out that little stuff soon and merge and bump. Thanks!

@stasfilin

This comment has been minimized.

Contributor

stasfilin commented Jan 19, 2018

@thornomad Hi, need to double check tests

@thornomad

This comment has been minimized.

Owner

thornomad commented Jan 19, 2018

PS - I had a hell of a time and failed getting pythong3.6 to work with travis -- but we do want them to pass locally. I just need to install that on my machine.

@sky-code

This comment has been minimized.

sky-code commented Mar 8, 2018

any update on this?

@thornomad

This comment has been minimized.

Owner

thornomad commented Mar 8, 2018

Hi there - thanks for checking ... I hadn't had time to work on this myself yet! Yikes! I was hoping to get those tests fixed before we release. I merged @stasfilin commit with a new feature branch:

https://github.com/thornomad/django-hitcount/tree/feature/support-20

Still, tests are not passing ...

https://travis-ci.org/thornomad/django-hitcount/builds/350858102

Need to figure out why so it doesn't break support for older versions of Django and Python.

@stasfilin

This comment has been minimized.

Contributor

stasfilin commented Mar 8, 2018

@thornomad @sky-code hi there, i will check tests today

@thornomad

This comment has been minimized.

Owner

thornomad commented Mar 9, 2018

@stasfilin - I think they are all passing now, pull from:

https://github.com/thornomad/django-hitcount/tree/feature/support-20

I ran out of time this morning but if all looks good can bundle a new release. check out that feature branch and let me know ... I haven't had time to wrap it up yet, will soon.

Fix flake8 errors
Signed-off-by: Stanislav Filin <stasfilinmusic@gmail.com>
@coveralls

This comment has been minimized.

coveralls commented Mar 9, 2018

Coverage Status

Coverage decreased (-0.8%) to 94.989% when pulling 468279b on stasfilin:django20_support into 76601ce on thornomad:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Mar 9, 2018

Coverage Status

Coverage decreased (-0.8%) to 94.989% when pulling 468279b on stasfilin:django20_support into 76601ce on thornomad:master.

@stasfilin

This comment has been minimized.

Contributor

stasfilin commented Mar 9, 2018

@thornomad Builds:
screen shot 2018-03-09 at 4 30 26 pm

About https://github.com/thornomad/django-hitcount/tree/feature/support-20 - all okay, I think we can merge

@thornomad

This comment has been minimized.

Owner

thornomad commented Mar 12, 2018

Should be all set not - release 1.3.0. Thanks!

@thornomad thornomad closed this Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment