New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWARM-123 - Provide extra configuration for Jolokia #134

Merged
merged 1 commit into from Sep 12, 2016

Conversation

2 participants
@bobmcwhirter
Contributor

bobmcwhirter commented Sep 9, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you created a JIRA and used it in the commit message?
  • Have you checked to ensure there aren't other open Pull Requests for the same issue?
  • Have you built the project locally prior to submission with mvn clean install?

Motivation

Particularly when running Jolokia within the context of a Keycloak-enabled
application, it would be fantastic to be able to also secure the Jolokia
endpoints with Keycloak.

Modifications

If org.wildfly.swarm:keycloak is present in a -swarm.jar, AND a property
named swarm.jolokia.keycloak.role is set to non-null, then the jolokia.war
is manipulated akin to:

jolokiaWar.as(Secured.class).protect().withRole( THE_ROLE );

Result

In the event Keycloak is available, and a property/config-value is set,
then Jolokia endpoints can be easily secured using the underlying Keycloak
infrastructure.

SWARM-123 - Provide extra configuration for Jolokia
Motivation
----------

Particularly when running Jolokia within the context of a Keycloak-enabled
application, it would be fantastic to be able to also secure the Jolokia
endpoints with Keycloak.

Modifications
-------------

If org.wildfly.swarm:keycloak is present in a -swarm.jar, AND a property
named swarm.jolokia.keycloak.role is set to non-null, then the jolokia.war
is manipulated akin to:

    jolokiaWar.as(Secured.class).protect().withRole( THE_ROLE );

Result
------

In the event Keycloak is available, and a property/config-value is set,
then Jolokia endpoints can be easily secured using the underlying Keycloak
infrastructure.

@kenfinnigan kenfinnigan merged commit ac18d97 into thorntail:master Sep 12, 2016

1 check passed

default Build finished.
Details

@bobmcwhirter bobmcwhirter deleted the bobmcwhirter:SWARM-123b branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment