This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
fixes #1375
Merged
fixes #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
Ladicek
force-pushed
the
fixes
branch
2 times, most recently
from
a3e79f8
to
b738e5d
Compare
- update to RESTEasy 3.9.3.SP1 - update to Jackson 2.10.2 - update to Jaeger client 0.34.1 and Apache Thrift 0.13.0 - update to OpenShift Rest Client Java 9.0.0.Final - update to SnakeYAML 1.24 Jackson 2.10 needs up to date SnakeYAML (1.24). This version adds some calls to `java.util.logging`. At the same time, Thorntail bootstrap uses SnakeYAML early and so it is required for SnakeYAML to not touch `java.util.logging`, which would prevent `logging` subsystem startup. The fix is to update SnakeYAML, but fork some of its classes and remove the `java.util.logging` calls (fortunately the number of classes that touch `java.util.logging` is very low), just like what we do with JBoss Modules. We then make sure that everyone uses SnakeYAML bundled in the Thorntail bootstrap. This has always been the case when running uberjar, because SnakeYAML is consumed via module dependency, and the SnakeYAML module we provide actually takes SnakeYAML from the bootstrap. When running from classpath, we just need to make sure that bootstrap is on classpath sooner than SnakeYAML, which is easy to do in the Maven plugin.
…s that were missing it
This is to fix several NPEs: - smallrye/smallrye-open-api#248 - smallrye/smallrye-open-api#237 For thorntail#248, see also: - smallrye/smallrye-open-api#251 - https://issues.redhat.com/browse/WFLY-13127 - smallrye/smallrye-open-api#290 For thorntail#237, see also: - smallrye/smallrye-open-api#325
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn clean install?