Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning use of classes on start page #1592

Open
werkstrom opened this issue Sep 29, 2019 · 3 comments

Comments

@werkstrom
Copy link

commented Sep 29, 2019

On startpage.html different classes are used for startPageCategories (first "row div" on the page) and the boxes below (the second "row div" on the page) and the margins within them are set differently resulting in uneven distances between columns in these two divs (slightly wider margin on the top row)

Adjusting styles.css and the card-deck class as per below appears to resolve the issue. This also adjusts to using rem (mainly) instead of px.

.card-deck {
  display: flex;
  flex-direction: column; }
  .card-deck .card {
    margin-bottom: 0.75rem; }
  @media (min-width: 576px) {
    .card-deck {
      flex-flow: row wrap;
      margin-right: -0.625rem;
      margin-left: -0.625rem; }
      .card-deck .card {
        display: flex;
        flex: 1 0 0%;
        flex-direction: column;
        margin-right: 0.625rem;
        margin-bottom: 0;
        margin-left: 0.625rem; } }
@thorsten

This comment has been minimized.

Copy link
Owner

commented Sep 30, 2019

Please don't change something in the CSS files, please use the SCSS files.

@thorsten thorsten self-assigned this Sep 30, 2019
@thorsten thorsten added this to To Do in 3.0.0-beta.3 via automation Sep 30, 2019
@thorsten thorsten added this to the 3.0 milestone Sep 30, 2019
@werkstrom

This comment has been minimized.

Copy link
Author

commented Sep 30, 2019

Are these classes present in the scss files? I can't find them there? I looked there first but then again, I'm not a (s)CSS-guru either 😉

@thorsten

This comment has been minimized.

Copy link
Owner

commented Oct 1, 2019

These classes look like directly from Bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3.0.0-beta.3
  
To Do
2 participants
You can’t perform that action at this time.