Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use universal build settings #16

Closed
wants to merge 3 commits into from
Closed

Use universal build settings #16

wants to merge 3 commits into from

Conversation

@gfontenot
Copy link
Collaborator

gfontenot commented Nov 4, 2015

Curry is a really simple framework, and it sucks to have to manage multiple
targets and schemes to properly distribute it. Instead, we can use some clever
xcconfigs
to let a single framework target (and a single scheme) build
multiple frameworks for us.

gfontenot added 2 commits Nov 4, 2015
Curry is a really simple framework, and it sucks to have to manage
multiple targets and schemes to properly distribute it. Instead, we can
use some clever xcconfigs to let a single framework target (and a single
scheme) build multiple frameworks for us.
@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Nov 4, 2015

I want to test this against some demo apps to make absolutely sure this works as advertised.

@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Nov 4, 2015

Confirmed that this works against https://github.com/gfontenot/platformtests

🎉

@paulyoung

This comment has been minimized.

Copy link
Contributor

paulyoung commented Nov 4, 2015

I've been thinking about this since I saw it in kylef/Mockingjay. Would be great if it's a viable solution!

@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Nov 4, 2015

Ditto. Ever since you pointed this out as a potential option, I haven't been able to stop thinking about it.

On Nov 3, 2015, at 18:30, Paul Young notifications@github.com wrote:

I've been thinking about this since I saw it in kylef/Mockingjay. Would be great if it's a viable solution!


Reply to this email directly or view it on GitHub.

@paulyoung

This comment has been minimized.

Copy link
Contributor

paulyoung commented Nov 20, 2015

The only potential downside I can see to this is described here: the-grid/Disc#9

@paulyoung

This comment has been minimized.

Copy link
Contributor

paulyoung commented Nov 20, 2015

Specifically:

Because Mockingjay is a universal framework, Xcode can't infer the correct device for the scheme so sometimes combinations like Disc-iOS > My Mac can be set. This means sometimes having to manually pick the correct device for the scheme before building or running tests.

@paulyoung

This comment has been minimized.

Copy link
Contributor

paulyoung commented Nov 20, 2015

But that's only a problem because we disabled implicit dependencies.

@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Nov 24, 2015

That's interesting though, and honestly might be enough of a PITA to avoid this (unfortunately).

@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Nov 24, 2015

I wish Apple would support this kind of thing natively.

@paulyoung

This comment has been minimized.

Copy link
Contributor

paulyoung commented Nov 24, 2015

There may be a way around it but I tried a few things and haven't been able to find one.

I want to reiterate that using the default build scheme settings, "Find Implicit Dependencies" is enabled and doesn't appear to be subject to that behavior.

@gfontenot

This comment has been minimized.

Copy link
Collaborator Author

gfontenot commented Dec 22, 2015

I'm going to go ahead and close this. I think it'd be nice, but it seems like it's more headache than it's worth.

@gfontenot gfontenot closed this Dec 22, 2015
@gfontenot gfontenot deleted the gf-universal branch Jul 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.