Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Xcode project generated by Swift PM #32

Closed
wants to merge 4 commits into from
Closed

Conversation

gfontenot
Copy link
Collaborator

@gfontenot gfontenot commented Aug 3, 2016

Instead of maintaining this ourselves, I think we should be able to use the
one generated for us by Swift Package Manager. This means that Carthage
still works (because it can still find an Xcode project), and it's less for
us to deal with overall.

Note that swift package manager generates an Xcode project for a universal
framework, so it might run into some of the same issues we saw in #16.

gfontenot added 2 commits Aug 3, 2016
This works with swiftenv to specify the swift version to use for compiling.
Instead of maintaining this ourselves, I think we should be able to use the
one generated for us by Swift Package Manager. This means that Carthage still
works (because it can still find an xcode project), and it's less for us to
deal with overall.
@tonyd256
Copy link
Contributor

@tonyd256 tonyd256 commented Aug 3, 2016

sure

@gfontenot
Copy link
Collaborator Author

@gfontenot gfontenot commented Aug 3, 2016

I want to run some more tests with existing projects (e.g., Argo) to make sure this doesn't break anything before we merge it.

gfontenot added 2 commits Aug 3, 2016
The default for these is later than we actually want. We can safely drop
these.
This brings us back to where we started! Huzzah!
@gfontenot
Copy link
Collaborator Author

@gfontenot gfontenot commented Mar 12, 2019

I'm not going to worry about this right now. I might come back and revisit it down the line at some point, but no promises.

@gfontenot gfontenot closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants