Add Italian localization #130
Conversation
| "Updated at %@" = "Aggiornato il %@"; | ||
|
|
||
| "Checking Weather..." = "Controllo il Meteo..."; | ||
| "Update Failed" = "Update non risucito"; |
There was a problem hiding this comment.
Should "risucito" be "riuscito"?
There was a problem hiding this comment.
Yep, sorry about that, typo. The sad thing is that I double checked the text twice 😓
|
Looks good to me based on my beginner/intermediate college italian 😄 🇮🇹 |
|
Thanks for this PR @andreamazz I'm looking over to today. Can you also localize https://github.com/thoughtbot/Tropos/blob/master/Resources/Other-Sources/en.lproj/InfoPlist.strings ? |
| "SlightSnow" = ", con bassa probabilità di nevicate"; | ||
| "GoodSnow" = ", con alta probabilità di nevicate"; | ||
|
|
||
| "Updated %@ at %@" = "Aggiornato il %@ alle %@"; |
There was a problem hiding this comment.
Rather than using the format string to do the localization what do you think about making the key for the localizations follow the same naming convention, Pascal case and add the missing english translations for them?
This would apply to a few in this file:
Updated %@ at %@ to UpdatedAtDateAndTime
Updated at %@ to UpdatedAtTime
Checking Weather... to CheckingWeather
Update Failed to UpdateFailed
|
Happy to do it! |
| @@ -0,0 +1,2 @@ | |||
| "CFBundleDisplayName" = "Tropos"; | |||
| "NSLocationWhenInUseUsageDescription" = "Tropos userà la tua posizione solo per scoprire le condizioni meteo attuali e quelle previste nella la tua zona"; | |||
There was a problem hiding this comment.
Should this have a period . on the end?
There was a problem hiding this comment.
Fixed in 96184f8
|
Thanks for your work on this. I've merged it in 5c062b6 |
|
👍 |
Hi. Since the project already supports localization I thought to start adding additional languages :)
This PR adds italian.