New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to ApplicationHelper#sort_order #1000

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@hanneskaeufler
Contributor

hanneskaeufler commented Oct 9, 2017

This method was previously entirely uncovered by the test suite.
Deleting it would still have all the tests pass when bundle exec rake && bunde exec appraisal rake. I recognize this is minor and the demo app will fail pretty obvious when started manually, but I like my test suites thorough :)

Edit: Also, congrats on 1000 PRs 馃構

Add test coverage to ApplicationHelper#sort_order
This method was previously entirely uncovered by the test suite.
Deleting it would still have all the tests pass.
@nickcharlton

This is great! Thanks.

And 馃帀 for crossing over 1000!

@nickcharlton nickcharlton merged commit ad7b7b4 into thoughtbot:master Oct 16, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

@hanneskaeufler hanneskaeufler deleted the hanneskaeufler:hk-add-sort_order-test-coverage branch Dec 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment