New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve german translation. #1002

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@hanneskaeufler
Contributor

hanneskaeufler commented Oct 11, 2017

German translation of "Clear search", "Search Resource" and "New resource" did not make any sense.

In order to be able to improve the german translation of "New post",
the string contatenation of "new" + resource had to be moved into
the i18n string instead of being performed inside the template. This
will help other locales as well I assume. To keep the current
behaviour for all other locales, I appended "%{resource}".

hanneskaeufler added some commits Oct 11, 2017

Improve german translation.
In order to be able to improve the german translation of "New post",
the string contatenation of "new" + resource had to be moved into
the i18n string instead of being performed inside the template. This
will help other locales as well I assume. To keep the current
behaviour for all other locales, I appended "%{resource}".
Improve german translation for edit/show item.
Again, german does not say "Editieren Resource" but "Resource editieren"
which means we have to put the resource into the i18n string.

@hanneskaeufler hanneskaeufler referenced this pull request Oct 16, 2017

Merged

Add and improve I18n for application templates #1004

5 of 5 tasks complete
new: "جديد"
edit_item: "تعديل %{item}"
show: "إظهار %{item}"
new: "جديد %{resource}"

This comment has been minimized.

@buren

buren Oct 16, 2017

Contributor

hm.. 🤔 This actually might be the other way around, name/item before the string... (but I don't know, since I personally don't speak arabic could check with a friend who does though).

@buren

buren Oct 16, 2017

Contributor

hm.. 🤔 This actually might be the other way around, name/item before the string... (but I don't know, since I personally don't speak arabic could check with a friend who does though).

This comment has been minimized.

@nickcharlton

nickcharlton Oct 18, 2017

Member

I had a chat with a colleague about this and apparently it is correct. You'll read it right-to-left, but because it should be rendered that way it'll make sense.

I'd be happy to be shown we're wrong though!

@nickcharlton

nickcharlton Oct 18, 2017

Member

I had a chat with a colleague about this and apparently it is correct. You'll read it right-to-left, but because it should be rendered that way it'll make sense.

I'd be happy to be shown we're wrong though!

@hanneskaeufler

This comment has been minimized.

Show comment
Hide comment
@hanneskaeufler

hanneskaeufler Dec 4, 2017

Contributor

Closing this in favor of a new one as suggested in #1004

Contributor

hanneskaeufler commented Dec 4, 2017

Closing this in favor of a new one as suggested in #1004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment