/administrate

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Circle 2.0. #1031

Merged
merged 1 commit into from Nov 24, 2017
+48 −13

Conversation

Reviewers

@sardaukar sardaukar

@mygulamali mygulamali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nickcharlton @sardaukar @mygulamali
@nickcharlton
Copy link
Member

nickcharlton commented Nov 23, 2017 •
edited

  • Use a Docker image for Ruby 2.4.1.
  • Use an image with node for JavaScript dependencies of Rails.
  • Use an image with a browser for integration tests.
  • Configure Postgres with an adjacent image.
  • Avoid race conditions by using dockerize.
  • Cache bundler dependencies between runs.

@nickcharlton nickcharlton force-pushed the nc-circle-workflows branch 2 times, most recently from e944b87 to d4b4e4e Nov 24, 2017

@mygulamali

mygulamali approved these changes Nov 24, 2017
View changes

Copy link

mygulamali left a comment

Some minor comments, otherwise LGTM! :shipit:

I should point out that I have zero knowledge of configuring CircleCI and my Docker is a bit rusty too, so you might want someone else to double check this PR first.
.circleci/config.yml Outdated
# Cache Dependencies
- type: cache-save
name: Store bundle cache
key: houndci-{{ checksum "Gemfile.lock" }}

This comment has been minimized.

Sign in to view
Copy link
@mygulamali

mygulamali Nov 24, 2017

Should the key for this cache be the same as the one on line 22?

This comment has been minimized.

Sign in to view
Copy link
@sardaukar

sardaukar Nov 24, 2017

Yep, that's pretty much needed @nickcharlton should be administrate-{{ checksum "Gemfile.lock" }}

This comment has been minimized.

Sign in to view
Copy link
@nickcharlton

nickcharlton Nov 24, 2017

Author Member

Ah, yeah. I missed that.
.circleci/config.yml Outdated

# Setup the database
- run: bundle exec rake db:create
- run: bundle exec rake db:schema:load

This comment has been minimized.

Sign in to view
Copy link
@mygulamali

mygulamali Nov 24, 2017

Could these two lines be replaced with one?

bundle exec rake db:create db:schema:load

This comment has been minimized.

Sign in to view
Copy link
@mygulamali

mygulamali Nov 24, 2017

Or alternatively: bundle exec rake db:setup ?
.circleci/config.yml Outdated
docker:
- image: circleci/ruby:2.4.1-node-browsers
environment:
PGHOST: 127.0.0.1

This comment has been minimized.

Sign in to view
Copy link
@mygulamali

mygulamali Nov 24, 2017

Is it possible to use localhost instead of the actual IP address here? Just to keep it more consistent with line 38.
@nickcharlton
Switch to Circle 2.0. 
* Use a Docker image for Ruby 2.4.1.
* Use an image with node for JavaScript dependencies of Rails.
* Use an image with a browser for integration tests.
* Configure Postgres with an adjacent image.
* Avoid race conditions by using `dockerize`.
* Cache bundler dependencies between runs.
Verified
This commit was signed with a verified signature.
@nickcharlton nickcharlton Nick Charlton
GPG key ID: 36CDE040F19FA37C Learn about signing commits
Loading status checks…
6ee1db4

@nickcharlton nickcharlton force-pushed the nc-circle-workflows branch from 91e5bdd to 6ee1db4 Nov 24, 2017

@sardaukar

sardaukar approved these changes Nov 24, 2017
View changes

Copy link

sardaukar left a comment

LGTM :shipit:

@nickcharlton nickcharlton merged commit 2bc89d6 into master Nov 24, 2017
2 checks passed

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!

@nickcharlton nickcharlton deleted the nc-circle-workflows branch Nov 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment