New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Administrate to work with Rails 5 #636

Merged
merged 14 commits into from Oct 4, 2016

Conversation

Projects
None yet
8 participants
@teoljungberg
Contributor

teoljungberg commented Aug 1, 2016

This PR upgrades Administrate to work with Rails 5. The changes
are backwards compatible to Rails 4.2 which we support.

Changes:

  • Set active_record.time_zone_aware_types for Rails 5.

  • Replace column_types
    It was removed in the following commit to rails/rails

  • "Sanitize" order parameters to quell warnings.

  • Add HTTP method shims
    This provides backwards compatibility from Rails 5 to 4.

    Inspiration:

  • Configure serving public assets to work with Rails 4 and 5.

  • Only set raise_in_transactional_callbacks if < Rails 5.
    The option is deprecated in Rails 5.

  • Upgrade ActionController configuration for Rails 5

  • Remove unused spec helper

  • Only remove the XML parser if < Rails 5

  • Add appraisals for rails 4.2 and 5.0.
    Add binstub for appraisal.

  • Lax Rails version requirement.
    Lock in 4.2 < Rails::VERSION < 5.1.

  • Use fork of administrate-field-image.
    Which relaxes the version requirement for Rails.

  • Upgrade rspec-rails

@maxehmookau

This comment has been minimized.

maxehmookau commented Aug 5, 2016

Any idea on when this might get merged? Administrate is great but missing Rails 5 support is a big issue right now. :(

@towen

This comment has been minimized.

towen commented Aug 10, 2016

Really looking forward to getting this PR pushed thru. Thanks for all your work on it @maxehmookau

@m-o-e

This comment has been minimized.

m-o-e commented Aug 21, 2016

There seem to be multiple independent Rails5 PRs and forks by now.

Could one of the administrate maintainers please signal
which PR is going to be merged and when?

teoljungberg added some commits Jul 7, 2016

Use fork of `administrate-field-image`
Which relaxes the version requirement for Rails.
Lax Rails version requirement
- Lock in `4.2 < Rails::VERSION < 5.1`
Add appraisals for rails 4.2 and 5.0
- Add binstub for appraisal.
Only set `raise_in_transactional_callbacks` if < Rails 5
The option is deprecated in Rails 5.
Add HTTP method shims
This provides backwards compatibility from Rails 5 to 4.

Inspiration:
- thoughtbot/clearance#639
- https://github.com/thoughtbot/high_voltage/pull/229/files

@danbee danbee force-pushed the rails-5 branch from c4922bf to 80dd2f1 Oct 4, 2016

@danbee danbee merged commit 80dd2f1 into master Oct 4, 2016

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
hound No violations found. Woof!

@zaiste zaiste referenced this pull request Oct 5, 2016

Closed

Rails 5 support #623

@preist

This comment has been minimized.

preist commented Oct 6, 2016

🎉

@esparta esparta referenced this pull request Oct 13, 2016

Closed

Upgrade to Rails 5 #1172

0 of 2 tasks complete
@j-dexx

This comment has been minimized.

j-dexx commented Oct 13, 2016

@danbee How close is a version release to rubygems that includes rails 5?

@imajes

This comment has been minimized.

imajes commented Oct 15, 2016

  1. Why was this PR picked over other Rails 5 PRs?
  2. The build fails with this PR. 👎 👎 👎
  3. Using a .find on column_types? That's pretty lazy. 👎 👎 👎
  4. As far as i can tell, changing the config for action_on_unpermitted_parameters to :log is simply lazy and insecure. wtf? 😡 😡 😡
@danbee

This comment has been minimized.

Collaborator

danbee commented Oct 19, 2016

@imajes:

  1. Because it was.
  2. The build fails on CI right now due to some weirdness with bundler. The build passes locally now.
  3. Please feel free to submit a PR with a better approach.
  4. You're right. This has been dealt with.

You made a couple of valid points here, but I'd appreciate it if you were less rude next time. Thanks.

@teoljungberg teoljungberg referenced this pull request Oct 24, 2016

Closed

Rails 5 #656

@nickcharlton nickcharlton deleted the rails-5 branch Dec 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment