Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hiding of search bar when none of searchable columns are used on index page #892

Merged
merged 1 commit into from Apr 27, 2018

Conversation

@pustomytnyk
Copy link
Contributor

pustomytnyk commented May 16, 2017

Untie search from representation of collection

@@ -134,7 +134,7 @@ def translate_with_resource(key)

def show_search_bar?
dashboard.attribute_types_for(
dashboard.collection_attributes
dashboard.all_attributes

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot May 16, 2017

Put a comma after the last parameter of a multiline method call.

@nickcharlton

This comment has been minimized.

Copy link
Member

nickcharlton commented May 19, 2017

Would you be able to add some tests to this?

@pustomytnyk

This comment has been minimized.

Copy link
Contributor Author

pustomytnyk commented May 19, 2017

@nickcharlton maybe after #843. It waits 20 days already.

@pustomytnyk pustomytnyk force-pushed the pustomytnyk:fix-hiding-search-bar branch from 2f5ba75 to 24a4673 Mar 17, 2018
@pustomytnyk

This comment has been minimized.

Copy link
Contributor Author

pustomytnyk commented Mar 17, 2018

@nickcharlton updated.

* Also unties search scope from representation of collection
@nickcharlton nickcharlton force-pushed the pustomytnyk:fix-hiding-search-bar branch from 24a4673 to cbffb1f Apr 27, 2018
@nickcharlton

This comment has been minimized.

Copy link
Member

nickcharlton commented Apr 27, 2018

It'd been a little while on this, so I took your branch and rebased. I'll merge it in now, thanks!

@nickcharlton nickcharlton merged commit f94c260 into thoughtbot:master Apr 27, 2018
5 checks passed
5 checks passed
Hound No violations found. Woof!
ci/circleci: ruby-2.2 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.3 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.4 Your tests passed on CircleCI!
Details
ci/circleci: ruby-2.5 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.