Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions for CircleCI #100

Closed
nbibler opened this issue Jul 30, 2015 · 4 comments
Closed

Instructions for CircleCI #100

nbibler opened this issue Jul 30, 2015 · 4 comments

Comments

@nbibler
Copy link

nbibler commented Jul 30, 2015

The README has instructions for using Appraisal with TravisCI. However, Suspenders was just updated to use CircleCI and yet Appraisal contains no information about CircleCI integration.

After searching around a bit, it does not appear to be a straightforward configuration setting in the circle.yml.

Are there any official Appraisal configuration settings for CircleCI? And if so, can they be added to the README?

@jferris
Copy link
Member

jferris commented Jul 30, 2015

You could install and run Appraisal on CircleCI, but I prefer to use Travis for projects that require a build matrix. Even if you get Appraisal working on CircleCI, you'll still have more hoops to jump through to get multiple Ruby versions going.

@sikachu any thoughts?

@nbibler
Copy link
Author

nbibler commented Jul 30, 2015

That's fair. Travis makes the matrix stuff (multiple language versions, environment settings, etc.) very simple.

It just seemed as though Thoughtbot was seemingly moving toward CircleCI with the Suspenders change, but yet wasn't doing it across all of the projects. Looking into it, I've kind of realized why - at least for Appraisal. As you mentioned, it seems to be incredibly complicated / brittle to do right now.

@jferris
Copy link
Member

jferris commented Jul 30, 2015

It just seemed as though Thoughtbot was seemingly moving toward CircleCI with the Suspenders change

Yeah, we definitely are. If Circle had better support for multiple versions, I would probably move my open source projects over.

@sikachu
Copy link
Contributor

sikachu commented Aug 3, 2015

I don't think Suspender's change affects Appraisals (or CI service change) in any way, as usually you will only testing your Rails application against only one set of gems and one version of Ruby, whereas for gem development (which we still run the test on Travis) you have to run it against multiple versions, and that's where Appraisals comes in to play.

For open source projects, I still don't see CircleCI as a viable choice as you can only have 1 concurrent build where on Travis you can spawn ~5 concurrent builds for free. I feel like unless you have a good reason to do so Travis is still a better option.

With that said, I don't mind if you would like to submit a PR to add section about how to config the test on CircleCI, with the caveat that they probably have to pay for additional container (as otherwise it would be just as running appraisal rake like you do it locally).

I'm going to close this, but please feel free to discuss further or submit a PR to add that.

@sikachu sikachu closed this as completed Aug 3, 2015
brenes added a commit to brenes/appraisal that referenced this issue May 5, 2016
Just as suggested in thoughtbot#100 instructions are added to Readme.md for using circle ci instead of travis.
sikachu pushed a commit that referenced this issue May 6, 2016
Just as suggested in #100 instructions are added to Readme.md for using
circle ci instead of travis.

Close #111, Fix #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants