Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Support ENV['BUNDLE_GEMFILE'] variable #23

Merged
merged 1 commit into from

2 participants

@radar

This is because this could potentially be set to something other than Gemfile.

For example, in Spree, we have a dummy application that lives at spec/dummy inside each engine component. Each engine component has a Gemfile at the root of its directory. The dummy applications contain no Gemfile, and so their config/boot.rb sets the ENV['BUNDLE_GEMFILE'] path to go back up to the root's Gemfile.

Appraisal doesn't acknowledge this environment variable, but should.

@radar radar @gemfile.load in File should look for BUNDLE_GEMFILE first
This is because this could *potentially* be set to something other than Gemfile.

For example, in Spree, we have a dummy application that lives at spec/dummy inside each engine component. Each engine component has a Gemfile at the root of its directory. The dummy applications contain no Gemfile, and so their config/boot.rb sets the ENV['BUNDLE_GEMFILE'] path to go back up to the root's Gemfile.

Appraisal doesn't acknowledge this environment variable, but should.
e41fdfc
@sikachu sikachu merged commit 43197cb into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 15, 2012
  1. @radar

    @gemfile.load in File should look for BUNDLE_GEMFILE first

    radar authored
    This is because this could *potentially* be set to something other than Gemfile.
    
    For example, in Spree, we have a dummy application that lives at spec/dummy inside each engine component. Each engine component has a Gemfile at the root of its directory. The dummy applications contain no Gemfile, and so their config/boot.rb sets the ENV['BUNDLE_GEMFILE'] path to go back up to the root's Gemfile.
    
    Appraisal doesn't acknowledge this environment variable, but should.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/appraisal/file.rb
View
2  lib/appraisal/file.rb
@@ -13,7 +13,7 @@ def self.each(&block)
def initialize
@appraisals = []
@gemfile = Gemfile.new
- @gemfile.load('Gemfile')
+ @gemfile.load(ENV['BUNDLE_GEMFILE'] || 'Gemfile')
run(IO.read(path)) if ::File.exists?(path)
end
Something went wrong with that request. Please try again.