Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support ENV['BUNDLE_GEMFILE'] variable #23

Merged
merged 1 commit into from Feb 15, 2012

Conversation

Projects
None yet
2 participants
Contributor

radar commented Feb 15, 2012

This is because this could potentially be set to something other than Gemfile.

For example, in Spree, we have a dummy application that lives at spec/dummy inside each engine component. Each engine component has a Gemfile at the root of its directory. The dummy applications contain no Gemfile, and so their config/boot.rb sets the ENV['BUNDLE_GEMFILE'] path to go back up to the root's Gemfile.

Appraisal doesn't acknowledge this environment variable, but should.

@radar radar @gemfile.load in File should look for BUNDLE_GEMFILE first
This is because this could *potentially* be set to something other than Gemfile.

For example, in Spree, we have a dummy application that lives at spec/dummy inside each engine component. Each engine component has a Gemfile at the root of its directory. The dummy applications contain no Gemfile, and so their config/boot.rb sets the ENV['BUNDLE_GEMFILE'] path to go back up to the root's Gemfile.

Appraisal doesn't acknowledge this environment variable, but should.
e41fdfc

@sikachu sikachu added a commit that referenced this pull request Feb 15, 2012

@sikachu sikachu Merge pull request #23 from radar/master
Support ENV['BUNDLE_GEMFILE'] variable
43197cb

@sikachu sikachu merged commit 43197cb into thoughtbot:master Feb 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment