Fix failing tests due to missing shoulda dependency #28

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

gregors commented Mar 17, 2012

fixes Issue #20

@@ -23,4 +23,5 @@ Gem::Specification.new do |s|
s.add_development_dependency('cucumber', '~> 1.0')
s.add_development_dependency('rspec', '~> 2.6')
s.add_development_dependency('aruba', '~> 0.4.2')
+ s.add_development_dependency('shoulda', '~> 2.11.3')
@gabebw

gabebw Mar 18, 2012

Contributor

I believe Appraisal only depends on shoulda-matchers, not shoulda itself - could you change it to shoulda-matchers instead?

@gregors

gregors Mar 19, 2012

Contributor

If I replace shoulda with shoulda-matchers the tests fail.
https://github.com/thoughtbot/appraisal/blob/master/features/gemspec.feature asking for shoulda explicitly.

@gabebw

gabebw Mar 19, 2012

Contributor

Ah. What if you change that feature to use shoulda-matchers too? Would that work? I'd like to have the most specific dependency possible, and not pulling in shoulda-context would be great.

@gabebw gabebw closed this in beaee3b Mar 19, 2012

Contributor

gabebw commented Mar 19, 2012

I looked into this and we don't use shoulda at all - that was just a random gem name. I changed it to use rake, since that's a runtime dependency anyway, and everything worked. Thanks for your pull!

Contributor

gregors commented Mar 19, 2012

thanks for clearing that up for me!

Contributor

gabebw commented Mar 19, 2012

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment