Fix `prependChildTo` behaviour #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@nhocki
Contributor

nhocki commented Jan 15, 2013

Similar to 589866d, prepending elements to another element in
a composite view, should not prepend to all the selectors that match
in the document.

We should use this.$ instead of just $ to prepend elements inside the view.

If you see the test the content gets added to an external container, so I have no idea is this is what you wanted or if this is actually a bug.

For me, a view should not be able to add/remove/edit elements inside other views.

Fix the scope for `prependChildTo`
Similar to 589866d, prepending elements to another element in
a composite view, should not prepend to all the selectors that match
in the document.
@nhocki

This comment has been minimized.

Show comment Hide comment
@nhocki

nhocki Mar 1, 2013

Contributor

@thoughtbot Is there a problem with this?

Contributor

nhocki commented Mar 1, 2013

@thoughtbot Is there a problem with this?

@jferris

This comment has been minimized.

Show comment Hide comment
@jferris

jferris Mar 7, 2013

Member

@nhocki Sorry, we haven't gotten a chance to look this over yet. We'll go through as soon as we can and let you know.

Member

jferris commented Mar 7, 2013

@nhocki Sorry, we haven't gotten a chance to look this over yet. We'll go through as soon as we can and let you know.

@acarpe

This comment has been minimized.

Show comment Hide comment
@acarpe

acarpe Apr 15, 2013

please merge this pull request, I'm suffering the same bug and using @nhocki fork

acarpe commented Apr 15, 2013

please merge this pull request, I'm suffering the same bug and using @nhocki fork

@christoomey

This comment has been minimized.

Show comment Hide comment
@christoomey

christoomey Apr 27, 2013

Member

Sorry for the delay in getting this merged in, but happy to report that this is now in master as of b0b20b7.

Member

christoomey commented Apr 27, 2013

Sorry for the delay in getting this merged in, but happy to report that this is now in master as of b0b20b7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment