Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sent_email_viewer] Remove whitespaces inside pre tag #493

Merged

Conversation

@ymtszw
Copy link
Contributor

commented Jul 22, 2019

Inside <pre> tags, whitespaces are shown literally. Thus rendered text bodies were "indented".

This PR removes whitespaces for indentation in <pre> tag from HTML-EEx source code.

[sent_email_viewer] Remove whitespaces inside pre tag
Inside `<pre>` tags, whitespaces are shown literally. Thus rendered text bodies were "indented".

This PR removes whitespaces for indentation in `<pre>` tag from HTML-EEx source code.
@ymtszw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

The CI failure is from current master, not related to this branch.
Will follow when master is updated (or, please ignore since this PR does not change Elixir code anyway.)

@maymillerricci
Copy link
Member

left a comment

👍 Thanks for this!

@maymillerricci maymillerricci merged commit e9ddba9 into thoughtbot:master Jul 26, 2019

1 check failed

ci/circleci Your tests failed on CircleCI
Details

@ymtszw ymtszw deleted the ymtszw:ymtszw-fix-indentation-in-pre-tag branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.