Permalink
Browse files

Removed position addon

  • Loading branch information...
1 parent 5f1176d commit 4621347ba0dbb2901fb87177b09c314b68a892fd Phil LaPier committed Mar 16, 2012
Showing with 0 additions and 31 deletions.
  1. +0 −1 app/assets/stylesheets/_bourbon.scss
  2. +0 −30 app/assets/stylesheets/addons/_position.scss
@@ -32,5 +32,4 @@
@import "addons/font-family";
@import "addons/hide-text";
@import "addons/html5-input-types";
-@import "addons/position";
@import "addons/timing-functions";
@@ -1,30 +0,0 @@
-@mixin position ($position: relative, $coordinates: 0 0 0 0) {
-
- @if type-of($position) == list {
- $coordinates: $position;
- $position: relative;
- }
-
- $top: nth($coordinates, 1);
- $right: nth($coordinates, 2);
- $bottom: nth($coordinates, 3);
- $left: nth($coordinates, 4);
-
- position: $position;
-
- @if not(unitless($top)) {
- top: $top;
- }
-
- @if not(unitless($right)) {
- right: $right;
- }
-
- @if not(unitless($bottom)) {
- bottom: $bottom;
- }
-
- @if not(unitless($left)) {
- left: $left;
- }
-}

5 comments on commit 4621347

@ream88
ream88 commented on 4621347 Mar 24, 2012

Any explanation why?

@scottmartin

I used this quite a bit. I'm moving it into my own file so my existing code still works but I too would like to know why you removed it.

@plapier
Contributor

I had a discussion with @ubuwaits, who introduced the position addon. The conclusion we came to was that we were not confident that it provides much added benefit. Is it faster to use the mixin than to write it out in normal CSS? Is the close any clearer to the user?

I could bring it back if it's frequently used feature?

@scottmartin

The main reason I found it useful was that it matches the shorthand of other properties like margin and padding. It was much easier than writing out the top, right, bottom, and left properties separately. Unless there is a native CSS shorthand for position I'm not aware of.

@ream88
ream88 commented on 4621347 Mar 28, 2012

Yeah, I liked the shorthand too. And I will stick with an old version of bourbon because of the removal, one our products uses are very "position-heavy" layout (lots of relative, a few absolute positionings). No time to rewrite it (again). :(

Please sign in to comment.