update _retina-image.scss to use correct prefix #196

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@lifeiscontent
Contributor

lifeiscontent commented Feb 23, 2013

as it specifically says in Apples documentation, you shouldn't use the @2x prefix.

A common file-naming convention for high-resolution images on the web is to prepend _2x >before the file extension; for example, myImage_2x.jpg. Don’t use @2x in the filename, >since the @ character in a URL is reserved as the delimiter separating the username and >password from the host in authentication URL schemes.

reference

@JoshuaJones

This comment has been minimized.

Show comment Hide comment
@JoshuaJones

JoshuaJones Feb 23, 2013

Sounds good. 👍

This should be getting more attention, I know a lot of devs who are using the @2x prefix. SubtlePatterns.com uses @2x in their file naming conventions too.

Sounds good. 👍

This should be getting more attention, I know a lot of devs who are using the @2x prefix. SubtlePatterns.com uses @2x in their file naming conventions too.

@lifeiscontent

This comment has been minimized.

Show comment Hide comment
@lifeiscontent

lifeiscontent Feb 24, 2013

Contributor

Cool, is there a place I can update the docs or is that somewhere on a server which I can't access?

Contributor

lifeiscontent commented Feb 24, 2013

Cool, is there a place I can update the docs or is that somewhere on a server which I can't access?

@plapier

This comment has been minimized.

Show comment Hide comment
@plapier

plapier Feb 24, 2013

Great to see Apple providing documentation around this. Bourbon documentation is managed in the gh-pages branch.

plapier commented Feb 24, 2013

Great to see Apple providing documentation around this. Bourbon documentation is managed in the gh-pages branch.

@plapier

This comment has been minimized.

Show comment Hide comment
@plapier

plapier Mar 24, 2013

I plan on merging this in, but it's going to break backwards compatibility. I want to be strategic about the merge and appropriate versioning. I'll make sure this gets in soon, possibly with bourbon v.3.2.0

plapier commented Mar 24, 2013

I plan on merging this in, but it's going to break backwards compatibility. I want to be strategic about the merge and appropriate versioning. I'll make sure this gets in soon, possibly with bourbon v.3.2.0

@lifeiscontent

This comment has been minimized.

Show comment Hide comment
@lifeiscontent

lifeiscontent Jun 25, 2013

Contributor

@plapier did you merge a different branch than this for the retina image code?

Contributor

lifeiscontent commented Jun 25, 2013

@plapier did you merge a different branch than this for the retina image code?

@plapier

This comment has been minimized.

Show comment Hide comment
@plapier

plapier Jun 25, 2013

Just pushed the stuff i've been working on. Somehow I missed this PR.

The code has diverged a bit from this PR. See my recent commit: 1bf573a

The suffix has changed to _2x per your recommendation.

plapier commented Jun 25, 2013

Just pushed the stuff i've been working on. Somehow I missed this PR.

The code has diverged a bit from this PR. See my recent commit: 1bf573a

The suffix has changed to _2x per your recommendation.

@plapier plapier closed this Jun 25, 2013

@lifeiscontent

This comment has been minimized.

Show comment Hide comment
@lifeiscontent

lifeiscontent Jun 25, 2013

Contributor

@plapier commented on 1bf573a

but other than that looks good. 👍

Contributor

lifeiscontent commented Jun 25, 2013

@plapier commented on 1bf573a

but other than that looks good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment