Skip to content

Adds a global flag around legacy support for IE. #206

Closed
wants to merge 1 commit into from

2 participants

@mkitt
mkitt commented Mar 4, 2013

The micro clearfix and inline-block mixins contain some pretty handy fixes for IE 8 and less, but not really needed in modern browsers. This pull request just adds a global flag whether to output the IE hacks or not. This can drastically cut down on the CSS output within a project.

While it'd be great to fully remove these hacks, I believe, having them remain available is way too useful still.

@mkitt mkitt Adds a global flag around legacy support for IE.
The micro `clearfix` and `inline-block` mixins contain some pretty handy fixes for IE 8 and less, but not really needed in modern browsers. This pull request just adds a global flag whether to output the IE hacks or not. This can drastically cut down on the CSS output within a project. 

While it'd be great to fully remove these hacks, I believe, having them remain available is way too useful still.
a12ac13
@plapier
plapier commented Mar 24, 2013

Bourbon prides itself on not having a configuration file. I'm not sure this variable is warranted though.

I recommend using the @inline-block mixin only if you need to support IE7 & IE6. IE8+ and all other modern browsers support the spec, so the spec should be used instead. Therefore the legacy conditional for IE is nearly useless. http://caniuse.com/#search=inline-block

The clearfix mixin is saving one line or 9 characters from a compressed stylesheet, which I don't think is worth the additional computation of a conditional and added global sass variable. All modern browsers will see the asterisk in front of the zoom property and ignore the property altogether. I'm not convinced it will make a difference of compile size or compilation times.

Perhaps you can provide real data of the file size difference to help us make a more informed decision here?

Closing the PR for the time being.

@plapier plapier closed this Mar 24, 2013
@mkitt
mkitt commented Mar 24, 2013

Fair enough, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.