Skip to content
Browse files

Lock capybara dependency to < 2.2

* Though capybara-webkit 1.1 works with capybara 2.2, it does not
  implement all new features.
  • Loading branch information...
1 parent daad70b commit 1dd9fcf1506c330e0afe140d37fa19b37dbdceef @mhoran mhoran committed Dec 24, 2013
Showing with 29 additions and 29 deletions.
  1. +2 −2 Gemfile.lock
  2. +1 −1 capybara-webkit.gemspec
  3. +13 −13 gemfiles/2.0.gemfile.lock
  4. +13 −13 gemfiles/2.1.gemfile.lock
View
4 Gemfile.lock
@@ -2,7 +2,7 @@ PATH
remote: .
specs:
capybara-webkit (1.1.0)
- capybara (~> 2.0, >= 2.0.2)
+ capybara (>= 2.0.2, < 2.2.0)
json
GEM
@@ -11,7 +11,7 @@ GEM
appraisal (0.4.0)
bundler
rake
- capybara (2.2.0)
+ capybara (2.1.0)
mime-types (>= 1.16)
nokogiri (>= 1.3.3)
rack (>= 1.0.0)
View
2 capybara-webkit.gemspec
@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
s.required_ruby_version = ">= 1.9.0"
- s.add_runtime_dependency("capybara", "~> 2.0", ">= 2.0.2")
+ s.add_runtime_dependency("capybara", ">= 2.0.2", "< 2.2.0")
s.add_runtime_dependency("json")
s.add_development_dependency("rspec", "~> 2.14.0")
View
26 gemfiles/2.0.gemfile.lock
@@ -1,8 +1,8 @@
PATH
remote: /home/mhoran/capybara-webkit
specs:
- capybara-webkit (1.0.0)
- capybara (~> 2.0, >= 2.0.2)
+ capybara-webkit (1.1.0)
+ capybara (>= 2.0.2, < 2.2.0)
json
GEM
@@ -20,9 +20,9 @@ GEM
xpath (~> 1.0.0)
childprocess (0.3.9)
ffi (~> 1.0, >= 1.0.11)
- diff-lcs (1.1.3)
+ diff-lcs (1.2.5)
ffi (1.9.0)
- json (1.8.0)
+ json (1.8.1)
mime-types (1.23)
mini_magick (3.5.0)
subexec (~> 0.2.1)
@@ -34,14 +34,14 @@ GEM
rack-test (0.6.2)
rack (>= 1.0)
rake (10.0.3)
- rspec (2.6.0)
- rspec-core (~> 2.6.0)
- rspec-expectations (~> 2.6.0)
- rspec-mocks (~> 2.6.0)
- rspec-core (2.6.4)
- rspec-expectations (2.6.0)
- diff-lcs (~> 1.1.2)
- rspec-mocks (2.6.0)
+ rspec (2.14.1)
+ rspec-core (~> 2.14.0)
+ rspec-expectations (~> 2.14.0)
+ rspec-mocks (~> 2.14.0)
+ rspec-core (2.14.7)
+ rspec-expectations (2.14.4)
+ diff-lcs (>= 1.1.3, < 2.0)
+ rspec-mocks (2.14.4)
rubyzip (0.9.9)
selenium-webdriver (2.33.0)
childprocess (>= 0.2.5)
@@ -67,6 +67,6 @@ DEPENDENCIES
capybara-webkit!
mini_magick
rake
- rspec (~> 2.6.0)
+ rspec (~> 2.14.0)
selenium-webdriver
sinatra
View
26 gemfiles/2.1.gemfile.lock
@@ -1,8 +1,8 @@
PATH
remote: /home/mhoran/capybara-webkit
specs:
- capybara-webkit (1.0.0)
- capybara (~> 2.0, >= 2.0.2)
+ capybara-webkit (1.1.0)
+ capybara (>= 2.0.2, < 2.2.0)
json
GEM
@@ -19,9 +19,9 @@ GEM
xpath (~> 2.0)
childprocess (0.3.9)
ffi (~> 1.0, >= 1.0.11)
- diff-lcs (1.1.3)
+ diff-lcs (1.2.5)
ffi (1.9.0)
- json (1.8.0)
+ json (1.8.1)
mime-types (1.23)
mini_magick (3.5.0)
subexec (~> 0.2.1)
@@ -33,14 +33,14 @@ GEM
rack-test (0.6.2)
rack (>= 1.0)
rake (10.0.3)
- rspec (2.6.0)
- rspec-core (~> 2.6.0)
- rspec-expectations (~> 2.6.0)
- rspec-mocks (~> 2.6.0)
- rspec-core (2.6.4)
- rspec-expectations (2.6.0)
- diff-lcs (~> 1.1.2)
- rspec-mocks (2.6.0)
+ rspec (2.14.1)
+ rspec-core (~> 2.14.0)
+ rspec-expectations (~> 2.14.0)
+ rspec-mocks (~> 2.14.0)
+ rspec-core (2.14.7)
+ rspec-expectations (2.14.4)
+ diff-lcs (>= 1.1.3, < 2.0)
+ rspec-mocks (2.14.4)
rubyzip (0.9.9)
selenium-webdriver (2.33.0)
childprocess (>= 0.2.5)
@@ -66,6 +66,6 @@ DEPENDENCIES
capybara-webkit!
mini_magick
rake
- rspec (~> 2.6.0)
+ rspec (~> 2.14.0)
selenium-webdriver
sinatra

6 comments on commit 1dd9fcf

@bobbytables

Would you mind elaborating on this commit? What in Capybara 2.2 is not supported by this library? Is that a reason to lock it out entirely?

@mhoran
mhoran commented on 1dd9fcf Jan 30, 2014

I detailed the missing features in the Capybara 2.2.0.rc1 release notes. We don't want users to try and use features that we know are not implemented. You could use capybara-webkit 1.1.0 until Capybara 2.2 support is added, which I hope to get to soon. Pull requests welcome!

@bobbytables

Cool, thanks for the link! I guess I need to signup for that mailing list.

@toothrot

This is great though: jnicklas/capybara@6b1e42d

@melnikaite-apoex

Capybara 2.3.0 have been released on June 2, 2014
Is anyone working on support new capybara?
May be it make sense to remove lock because of some bugfixes in capybara?

@mhoran
mhoran commented on 1dd9fcf Jun 11, 2014

The lock is there due to new features introduced in Capybara 2.2 which have not yet been implemented in capybara-webkit. There are likely new features in Capybara 2.3 which need to be implemented as well -- I haven't yet had the chance to look.

Please sign in to comment.
Something went wrong with that request. Please try again.