Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Rename confusing method

  • Loading branch information...
commit 3ebe0fa577b1f0294906d8668691842e6ccccfbd 1 parent 67d5e3d
@jferris jferris authored
Showing with 4 additions and 5 deletions.
  1. +3 −4 src/Connection.cpp
  2. +1 −1  src/Connection.h
View
7 src/Connection.cpp
@@ -25,7 +25,6 @@ Connection::Connection(QTcpSocket *socket, WebPage *page, QObject *parent) :
connect(m_page, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool)));
}
-
void Connection::commandReady(QString commandName, QStringList arguments) {
m_queuedCommand = m_commandFactory->createCommand(commandName.toAscii().constData(), arguments);
if (m_page->isLoading())
@@ -46,7 +45,7 @@ void Connection::startCommand() {
SLOT(finishCommand(Response *)));
m_runningCommand->start();
} else {
- pageLoadFailed();
+ writePageLoadFailure();
}
}
@@ -64,13 +63,13 @@ void Connection::pendingLoadFinished(bool success) {
if (m_pageSuccess) {
writeResponse(m_pendingResponse);
} else {
- pageLoadFailed();
+ writePageLoadFailure();
}
}
}
}
-void Connection::pageLoadFailed() {
+void Connection::writePageLoadFailure() {
m_pageSuccess = true;
QString message = m_page->failureString();
writeResponse(new Response(false, message));
View
2  src/Connection.h
@@ -23,7 +23,7 @@ class Connection : public QObject {
private:
void startCommand();
void writeResponse(Response *response);
- void pageLoadFailed();
+ void writePageLoadFailure();
QTcpSocket *m_socket;
Command *m_runningCommand;
Please sign in to comment.
Something went wrong with that request. Please try again.