Skip to content
This repository
Browse code

Rename confusing method

  • Loading branch information...
commit 3ebe0fa577b1f0294906d8668691842e6ccccfbd 1 parent 67d5e3d
Joe Ferris authored March 21, 2012
7  src/Connection.cpp
@@ -25,7 +25,6 @@ Connection::Connection(QTcpSocket *socket, WebPage *page, QObject *parent) :
25 25
   connect(m_page, SIGNAL(pageFinished(bool)), this, SLOT(pendingLoadFinished(bool)));
26 26
 }
27 27
 
28  
-
29 28
 void Connection::commandReady(QString commandName, QStringList arguments) {
30 29
   m_queuedCommand = m_commandFactory->createCommand(commandName.toAscii().constData(), arguments);
31 30
   if (m_page->isLoading())
@@ -46,7 +45,7 @@ void Connection::startCommand() {
46 45
             SLOT(finishCommand(Response *)));
47 46
     m_runningCommand->start();
48 47
   } else {
49  
-    pageLoadFailed();
  48
+    writePageLoadFailure();
50 49
   }
51 50
 }
52 51
 
@@ -64,13 +63,13 @@ void Connection::pendingLoadFinished(bool success) {
64 63
       if (m_pageSuccess) {
65 64
         writeResponse(m_pendingResponse);
66 65
       } else {
67  
-        pageLoadFailed();
  66
+        writePageLoadFailure();
68 67
       }
69 68
     }
70 69
   }
71 70
 }
72 71
 
73  
-void Connection::pageLoadFailed() {
  72
+void Connection::writePageLoadFailure() {
74 73
   m_pageSuccess = true;
75 74
   QString message = m_page->failureString();
76 75
   writeResponse(new Response(false, message));
2  src/Connection.h
@@ -23,7 +23,7 @@ class Connection : public QObject {
23 23
   private:
24 24
     void startCommand();
25 25
     void writeResponse(Response *response);
26  
-    void pageLoadFailed();
  26
+    void writePageLoadFailure();
27 27
 
28 28
     QTcpSocket *m_socket;
29 29
     Command *m_runningCommand;

0 notes on commit 3ebe0fa

Please sign in to comment.
Something went wrong with that request. Please try again.