Simulate browsers events more closely

thoughtbot · Jan 27, 2012 · 51c4dfe · 51c4dfe
1 parent 16c1637
commit 51c4dfe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/spec/driver_spec.rb b/spec/driver_spec.rb
@@ -637,12 +637,12 @@
 
     it "triggers radio input events" do
       subject.find("//input[@type='radio']").first.set(true)
-      subject.find("//li").map(&:text).should == %w(mousedown mouseup click change)
+      subject.find("//li").map(&:text).should == %w(mousedown mouseup change click)
     end
 
     it "triggers checkbox events" do
       subject.find("//input[@type='checkbox']").first.set(true)
-      subject.find("//li").map(&:text).should == %w(mousedown mouseup click change)
+      subject.find("//li").map(&:text).should == %w(mousedown mouseup change click)
     end
   end
 

diff --git a/src/capybara.js b/src/capybara.js
@@ -181,17 +181,13 @@ Capybara = {
       this.trigger(index, "blur");
 
     } else if (type === "checkbox" || type === "radio") {
-      node.checked = (value === "true");
-      this.trigger(index, "mousedown");
-      this.trigger(index, "mouseup");
-      this.trigger(index, "click");
-      this.trigger(index, "change");
+      if (node.checked != (value === "true")) {
+        this.click(index)
+      }
 
     } else if (type === "file") {
       this.lastAttachedFile = value;
-      this.trigger(index, "mousedown");
-      this.trigger(index, "mouseup");
-      this.trigger(index, "click");
+      this.click(index)
 
     } else {
       node.value = value;