Add deprecation warnings to legacy window methods

* Capybara 2.3 provides a new window API.
thoughtbot · Jul 14, 2014 · 99f4a88 · 99f4a88
1 parent e49886d
commit 99f4a88
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/capybara/webkit/browser.rb b/lib/capybara/webkit/browser.rb
@@ -126,13 +126,21 @@ def get_window_handles
       JSON.parse(command('GetWindowHandles'))
     end
 
-    alias_method :window_handles, :get_window_handles
+    def window_handles
+      warn '[DEPRECATION] Capybara::Webkit::Browser#window_handles ' \
+        'is deprecated. Please use Capybara::Session#windows instead.'
+      get_window_handles
+    end
 
     def get_window_handle
       command('GetWindowHandle')
     end
 
-    alias_method :window_handle, :get_window_handle
+    def window_handle
+      warn '[DEPRECATION] Capybara::Webkit::Browser#window_handle ' \
+        'is deprecated. Please use Capybara::Session#current_window instead.'
+      get_window_handle
+    end
 
     def accept_confirm(options)
       command("SetConfirmAction", "Yes", options[:text])

diff --git a/lib/capybara/webkit/driver.rb b/lib/capybara/webkit/driver.rb
@@ -97,6 +97,8 @@ def status_code
     end
 
     def resize_window(width, height)
+      warn '[DEPRECATION] Capybara::Webkit::Driver#resize_window ' \
+        'is deprecated. Please use Capybara::Window#resize_to instead.'
       resize_window_to(current_window_handle, width, height)
     end