Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Support `:numpad8` for `send_keys` method #1068

Merged
merged 1 commit into from Jul 21, 2018

Conversation

@pocke
Copy link
Contributor

commented Jul 21, 2018

:numpad9 is duplicated instead of :numpad8, so send_keys method raises an error when it receives :numpad8.
We can reproduce this behaviour with the added test case.

This pull request fixes the problem.

Note

I found this bug with RUBYOPT=-w. For example: (The second warning)

$ ruby -Ilib -rcapybara-webkit -e ''
/path/to/lib/ruby/gems/2.6.0/gems/addressable-2.5.2/lib/addressable/idna/pure.rb:154: warning: assigned but unused variable - startercc
/path/to/lib/capybara/webkit/node.rb:217: warning: duplicated when clause is ignored
[Bug fix] Support `:numpad8` for `send_keys` method
`:numpad9` is duplicated instead of `:numpad8`, so `send_keys` method raises an error when it receives `:numpad8`.
We can reproduce this behaviour with the added test case.

This pull request fixes the problem.

Note
===

I found this bug with `RUBYOPT=-w`.  For example: (The second warning)

```
$ ruby -Ilib -rcapybara-webkit -e ''
/path/to/lib/ruby/gems/2.6.0/gems/addressable-2.5.2/lib/addressable/idna/pure.rb:154: warning: assigned but unused variable - startercc
/path/to/lib/capybara/webkit/node.rb:217: warning: duplicated when clause is ignored
```

@mhoran mhoran merged commit 41c4306 into thoughtbot:master Jul 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mhoran

This comment has been minimized.

Copy link
Collaborator

commented Jul 21, 2018

Thanks!

@pocke pocke deleted the pocke:numpad8 branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.