select_option doesn't always change value or trigger change event #26

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@jemmyw
Contributor
jemmyw commented Apr 20, 2011

In a single value select calling select_option puts the "selected" attribute on the option, but does not remove it from the previous option, causing the value to be dependent on the option ordering.

Calling select_option doesn't trigger a change event on the select.

@skippy
skippy commented Apr 23, 2011

ah! I ran into this issue as well. thank you for the patch!

@j16r
Contributor
j16r commented Apr 28, 2011

Yep, I'm hitting this issue as well, basically select is completely useless for me unless I have only 1 option. Patch fixes it.

@tmacedo tmacedo pushed a commit to tmacedo/capybara-webkit that referenced this pull request May 13, 2011
Tiago Macedo Fix for #26, select options with selected and trigger change
Conflicts:

	src/capybara.js
388efb6
@jferris
Member
jferris commented May 25, 2011

Thanks for the patch. I merged this in.

@jferris jferris closed this May 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment