passed all javascript driver specs #32

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

hotchpotch commented Apr 23, 2011

Hi,

I implmented drag_to javascript.

But if my javascript code append to src/capybara.js, raise ReferenceError ...
'undefined:1 ReferenceError: Can't find variable: Capybara'
Sorry I don't understand that error.
(If capbara.js's filesize change, QResource can't read src/capybara.js ? )

Now my javascript code append to node.rb that is dirty ...

Owner

jferris commented Apr 25, 2011

I think that error happens when capybara.js isn't valid. Can you send a link to your commit that changes capybara.js?

Contributor

hotchpotch commented Apr 26, 2011

Hi, I commited changes capybara.js.

That code rake spec failed .

'''
.undefined:1 ReferenceError: Can't find variable: Capybara
Fundefined:1 ReferenceError: Can't find variable: Capybara
F..undefined:1 ReferenceError: Can't find variable: Capybara
Fundefined:1 ReferenceError: Can't find variable: Capybara
F...undefined:1 ReferenceError: Can't find variable: Capybara
...more fail...
'''

Owner

jferris commented May 3, 2011

I figured out that error - it was a weird one. Apparently Qt automatically compresses resources once they reach a certain size, so adding those functions to capybara.js crossed the threshold. I added a commit to uncompress the resource when necessary, and now everything is green again. Thanks for the patch!

@jferris jferris closed this May 3, 2011

Contributor

hotchpotch commented May 4, 2011

I understood from your explanation why capybara.js raise ReferenceError.

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment