Relax capybara dependency in gemspec to support Capybara 1.0.0.beta1 #37

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
7 participants
@guilleiguaran

No description provided.

@agibralter

This comment has been minimized.

Show comment Hide comment
@agibralter

agibralter Apr 27, 2011

Contributor

Hmm I think >= can be dangerous... Why not release a capybara-webkit beta to match the caypbara beta and support ~> 1.0?

Contributor

agibralter commented Apr 27, 2011

Hmm I think >= can be dangerous... Why not release a capybara-webkit beta to match the caypbara beta and support ~> 1.0?

@jc00ke

This comment has been minimized.

Show comment Hide comment
@jc00ke

jc00ke Apr 28, 2011

Contributor

+1 on relaxing, don't care how. If capybara-webkit works with capybara 1.0.0.beta1 it would be nice to match as @agibralter said.

Contributor

jc00ke commented Apr 28, 2011

+1 on relaxing, don't care how. If capybara-webkit works with capybara 1.0.0.beta1 it would be nice to match as @agibralter said.

@agibralter

This comment has been minimized.

Show comment Hide comment
@agibralter

agibralter Apr 28, 2011

Contributor

Well it's fine if capybara-webkit doesn't match version number... but I was just saying that capybara-webkit 0.3.x.betax could match capybara 1.0.x.betax

Contributor

agibralter commented Apr 28, 2011

Well it's fine if capybara-webkit doesn't match version number... but I was just saying that capybara-webkit 0.3.x.betax could match capybara 1.0.x.betax

@jc00ke

This comment has been minimized.

Show comment Hide comment
@jc00ke

jc00ke Apr 28, 2011

Contributor

Just a note: I forked this repo and changed the runtime dependency to capybara 1.0.0.beta1. I'm specifying capybara 1.0.0.beta1 in my app's Gemfile too and all specs pass. Haven't ran this repo's specs though.

Contributor

jc00ke commented Apr 28, 2011

Just a note: I forked this repo and changed the runtime dependency to capybara 1.0.0.beta1. I'm specifying capybara 1.0.0.beta1 in my app's Gemfile too and all specs pass. Haven't ran this repo's specs though.

@guilleiguaran

This comment has been minimized.

Show comment Hide comment
@guilleiguaran

guilleiguaran Apr 29, 2011

"> 1.0" or "> 1.0.0" doesn't work since is a beta version, I will change it to "~> 1.0.0.beta1"

"> 1.0" or "> 1.0.0" doesn't work since is a beta version, I will change it to "~> 1.0.0.beta1"

@jnimety

This comment has been minimized.

Show comment Hide comment
@jnimety

jnimety May 5, 2011

+1

jnimety commented May 5, 2011

+1

@sobrinho

This comment has been minimized.

Show comment Hide comment
@sobrinho

sobrinho May 8, 2011

+1

sobrinho commented May 8, 2011

+1

@leonid-shevtsov

This comment has been minimized.

Show comment Hide comment
@leonid-shevtsov

leonid-shevtsov May 9, 2011

+1

@jferris

This comment has been minimized.

Show comment Hide comment
@jferris

jferris May 25, 2011

Owner

I merged in the patch and pushed as 1.0.0.beta1. All the tests run successfully but I have yet to upgrade an app to capybara 1.0.0.anything so I haven't actually tried this out.

Owner

jferris commented May 25, 2011

I merged in the patch and pushed as 1.0.0.beta1. All the tests run successfully but I have yet to upgrade an app to capybara 1.0.0.anything so I haven't actually tried this out.

@jferris jferris closed this May 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment