Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #125 #385

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

miks commented Sep 5, 2012

No description provided.

Collaborator

mhoran commented Sep 6, 2012

This is actually unrelated to #125, which was specific to the difference between GNU make and BSD make on FreeBSD. I've seen qmake-qt4 as the qmake binary on multiple systems (CentOS, for example), so this isn't really FreeBSD specific. Perhaps we should just make the documentation more clear in that you should set your QMAKE environment variable to the proper qmake binary for successful installation.

Contributor

miks commented Sep 6, 2012

#125 is about making capybara-webkit working on FreeBSD, so maybe this is related.
On other side, normally there will never be "qmake" binary on FreeBSD, only qmake-qt4.
My goal was to make this gem more usable on FreeBSD without specifying QMAKE env variable in various places (CI, rails projects, etc)

Owner

jferris commented Nov 9, 2012

Can we change this so that we don't repeat the ENV['QMAKE'] || portion? Maybe extract the case statement to a default_qmake_binary method and then do ENV['QMAKE'] || default_qmake_binary?

Owner

jferris commented Nov 16, 2012

We decided a while back to stop trying to guess the qmake binary just because of how many systems there are, but it doesn't seem to have decreased the number of posts in GitHub issues, Stackoverflow, or the mailing list related to compile capybara-webkit.

I merged this in, and I think it's reasonable to do a combination of detection and allowing overriding. Hopefully there aren't too many variations on the qmake name.

@jferris jferris closed this Nov 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment