GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
node.inner_html # return the inner_html of the node
node.inner_html = '<small>foobar</small>' # update the inner_html of the node
Add inner_html and inner_html= methods
The value parameter here is acting as a Control Couple. It would be better to send a different message for setting vs getting the HTML and remove this conditional.
Thanks for the pull request. I had one comment about the implementation. If you want to take a look at that, I'd like to get this merged in.
Using separated methods to set and get the innerHTML
@jferris Is it good now?
and thank you for the review 😄
yes, i forgot to use camel case :wink2:
do i need to do something more to this be pulled?
Nope - thanks for pinging me on this. I merged this into master.