Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Offline application cache #518

Merged
merged 3 commits into from Aug 18, 2014

Conversation

Projects
None yet
3 participants
Contributor

betelgeuse commented May 2, 2013

Here's support for the Offline Application Cache specification. I didn't have clear idea on what would be your preferred approach to configuring the directory where the SQLite files are stored so feel free to provide feedback on that.

Contributor

betelgeuse commented Jul 1, 2013

Ping. I think this would be a useful addition. Anything I would need to do?

Collaborator

mhoran commented Aug 14, 2013

@betelgeuse, could you rebase on the latest master?

Contributor

betelgeuse commented Aug 28, 2013

@mhoran do you happen to know if homebrew allows me to have qt4 and qt5 side by side so that installing it in order to rebase allows me to keep testing with envs that have qt4 in production?

Contributor

betelgeuse commented Oct 3, 2013

@mhoran it applied cleanly with a rebase and tests passed, was there something I missed for you to ask for rebase?

Contributor

betelgeuse commented Dec 14, 2013

@mhoran ping

tdg5 commented Feb 3, 2014

+1

Contributor

betelgeuse commented Jul 15, 2014

@mhoran seems like there was another release without this merged. Any hopes of getting someone with push access to look to merge this finally?

Collaborator

mhoran commented Jul 15, 2014

Sorry about that, @betelgeuse. I meant to check in with you on this after the last release. We're in the process of merging Capybara 2.4 support but I'll take a look at this once we've worked that out.

Collaborator

mhoran commented Jul 17, 2014

@betelgeuse, would you mind rebasing and pushing this up again so we can ensure it runs against the current CI configuration? It also looks that there's a merge conflict with the current master that should be easy to resolve. Thanks!

betelgeuse added some commits May 1, 2013

@betelgeuse betelgeuse Initial Application Cache Support
Tests passing for a simple application cache support. To be added is
better handling of the tmp path and resetting testing at least.
567ba92
@betelgeuse betelgeuse App Offline Cache driver.reset! support 51b68f3
@betelgeuse betelgeuse Use offline app cache support when ./tmp/ exists
In Rails projects it's a sure bet that tmp exists so this automatically
covers most people. With the README addition other people know to create
the directory.
a907370
Contributor

betelgeuse commented Jul 17, 2014

@mhoran pushed and travis is currently running it (at least some combos have passed)

Collaborator

mhoran commented Jul 17, 2014

Great, thanks! If all goes green we'll get this merged for the next release.

@mhoran mhoran merged commit a907370 into thoughtbot:master Aug 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Collaborator

mhoran commented Aug 18, 2014

This was released in capybara-webkit 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment