Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding ability to render webpage to a PNG #62

Merged
merged 2 commits into from Jul 5, 2011

Conversation

Projects
None yet
8 participants
Contributor

nicholaides commented May 26, 2011

The driver has a #render method which takes a destination file path and
an options hash for setting the dimensions of the browser's viewport.

+100

or just +1

mattm commented Jun 21, 2011

Definitely. +1

+1

+1

trkoch commented Jun 23, 2011

+1

Owner

mike-burns commented Jun 29, 2011

Hi Mike, we'd love to take this pull request but it no longer applies cleanly. Can you rebase and resubmit? We'll take the pull request after you do this.

While you're doing that: we had a talk about the code from Phantom.js. It's BSD-licensed, which is good. Can you remove the comment from inline in the code and instead mention in the README that this borrows code from Phantom.js?

Thanks,
-Mike

Contributor

nicholaides commented Jun 29, 2011

Sure thing. I'll ping you in a day or so when it's done.

nicholaides added some commits May 26, 2011

@nicholaides nicholaides Adding ability to render webpage to a PNG
The driver has a #render method which takes a destination file path and
an options hash for setting the dimensions of the browser's viewport
1787324
@nicholaides nicholaides Documenting that some code was borrowed from Phantom.js 37b3d24
Contributor

nicholaides commented Jul 3, 2011

Alrighty. I made these changes and rebased.

@mike-burns mike-burns merged commit 37b3d24 into thoughtbot:master Jul 5, 2011

Owner

mike-burns commented Jul 5, 2011

Fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment