Permalink
Browse files

Follow Bundler conventions for file and test file lists in the gemspec

Closes #127
  • Loading branch information...
1 parent 003f78a commit 11456c406e9ee0d1e9b9a7b30279cb46e3ca2771 @joshuaclayton joshuaclayton committed Mar 6, 2011
Showing with 2 additions and 2 deletions.
  1. +2 −2 clearance.gemspec
View
@@ -15,8 +15,8 @@ Gem::Specification.new do |s|
"LICENSE",
"README.md"
]
- s.files = Dir['[A-Z]*', 'app/**/*', 'config/**/*', 'lib/**/*', 'features/**/engine/**/*']
- s.test_files = Dir['spec/**/*', 'test/**/*']
+ s.files = `git ls-files`.split("\n")
@croaky

croaky Oct 10, 2011

Owner

Josh, is this too aggressive? It seems weird to include Rakefile, cucumber.yml, .rspec, etc., and potentially dangerous to include db/schema.rb

@joshuaclayton

joshuaclayton Oct 10, 2011

Owner

Can you foresee a problem with this? By default, when you generate a new gem with bundler, it uses this syntax. The reason I changed this was because during a refactor, certain files got forgotten here and the generator wasn't working correctly.

+ s.test_files = `git ls-files -- {test,features}/*`.split("\n")
s.rdoc_options = ["--charset=UTF-8"]
s.require_paths = ["lib"]

0 comments on commit 11456c4

Please sign in to comment.