Skip to content

Commit

Permalink
Follow Bundler conventions for file and test file lists in the gemspec
Browse files Browse the repository at this point in the history 
Closes #127
  • Loading branch information
@joshuaclayton
joshuaclayton committed Mar 6, 2011
1 parent 003f78a commit 11456c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions clearance.gemspec
View file
Expand Up @@ -15,8 +15,8 @@ Gem::Specification.new do |s|
"LICENSE", "LICENSE",
"README.md" "README.md"
] ]
s.files = Dir['[A-Z]*', 'app/**/*', 'config/**/*', 'lib/**/*', 'features/**/engine/**/*'] s.files = `git ls-files`.split("\n")

This comment has been minimized.

Sign in to view

Copy link
@croaky

croaky Oct 10, 2011

Contributor

Josh, is this too aggressive? It seems weird to include Rakefile, cucumber.yml, .rspec, etc., and potentially dangerous to include db/schema.rb

This comment has been minimized.

Sign in to view

Copy link
@joshuaclayton

joshuaclayton Oct 10, 2011

Author Contributor

Can you foresee a problem with this? By default, when you generate a new gem with bundler, it uses this syntax. The reason I changed this was because during a refactor, certain files got forgotten here and the generator wasn't working correctly.
s.test_files = Dir['spec/**/*', 'test/**/*'] s.test_files = `git ls-files -- {test,features}/*`.split("\n")


s.rdoc_options = ["--charset=UTF-8"] s.rdoc_options = ["--charset=UTF-8"]
s.require_paths = ["lib"] s.require_paths = ["lib"]
Expand Down

0 comments on commit 11456c4

Please sign in to comment.