Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not update ActionController::Base::rescue_responses #72

Closed
josephholsten opened this issue Feb 20, 2010 · 2 comments
Closed

Should not update ActionController::Base::rescue_responses #72

josephholsten opened this issue Feb 20, 2010 · 2 comments

Comments

@josephholsten
Copy link

clearance/lib/clearance/extensions/rescue.rb:2 tries to call update on ActionController::Base::rescue_responses, which no longer exists in Rails 3.

A quick grep shows that rescue_responses lives on in ActionDispatch::ShowExceptions::rescue_responses, but I don't yet know if they are identical.
@croaky
Copy link
Contributor

croaky commented Feb 21, 2010

Potential fix was included in a comment on #21 by Peter Haza. Looking into this now.

@croaky
Copy link
Contributor

croaky commented Feb 21, 2010

Committed a fix:

http://github.com/thoughtbot/clearance/commit/bdf679bde6a6b777358ab53cfba4c7533282125d

Please give it a whirl and report back!

qrush pushed a commit to qrush/clearance that referenced this issue May 24, 2012
[thoughtbot#72] Rails3 fix for ActionController::Base::rescue_respons…
bdf679b 
…es removal
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@croaky @josephholsten