Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Should not update ActionController::Base::rescue_responses #72

Closed
josephholsten opened this Issue Feb 20, 2010 · 2 comments

Comments

Projects
None yet
2 participants

clearance/lib/clearance/extensions/rescue.rb:2 tries to call update on ActionController::Base::rescue_responses, which no longer exists in Rails 3.

A quick grep shows that rescue_responses lives on in ActionDispatch::ShowExceptions::rescue_responses, but I don't yet know if they are identical.

Contributor

croaky commented Feb 21, 2010

Potential fix was included in a comment on #21 by Peter Haza. Looking into this now.

Contributor

croaky commented Feb 21, 2010

Committed a fix:

http://github.com/thoughtbot/clearance/commit/bdf679bde6a6b777358ab53cfba4c7533282125d

Please give it a whirl and report back!

qrush pushed a commit to qrush/clearance that referenced this issue May 24, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment