fix for file system order bug in linux/tddium #238

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

narath commented Dec 7, 2012

In order for clearance integration tests to work on linux systems (as used by tddium) you need to include all the integration helper files explicity since the sort order on the linux systems is not the same as on mac systems, and without it all specs will fail.

In order for clearance integration tests to work on linux systems (as…
… used by tddium) you need to include all the integration helper files explicity since the sort order on the linux systems is not the same as on mac systems, and without it all specs will fail.
Owner

mike-burns commented Dec 31, 2012

Hi @narath , thanks for this!

I'm all for adding require everywhere (no joke; I love require), but I cannot reproduce the problem you suggest. Is there a particular FS I need, or something else?

Contributor

narath commented Jan 1, 2013

Hey Mike,

No worries, the error is a little obscure for most of Rails community since we mostly use Macs for development.

Tddium uses linux for their deployment so it orders the requires differently. If you setup a test app with clearance, with a free tedium account and do a test deploy that should reproduce the error (tddium will break on the clearance specs).

The error can be reproduced on Mac's if you add the .sort to the require line, and test the app (at least it reproduced it with the app we were developing with).

Hope that helps, let me know if you still can't reproduce it, and I'll try a simple other test app and see if our app was just a "special case".

~Narath

On Monday, December 31, 2012 at 9:52 AM, Mike Burns wrote:

Hi @narath (https://github.com/narath) , thanks for this!
I'm all for adding require everywhere (no joke; I love require), but I cannot reproduce the problem you suggest. Is there a particular FS I need, or something else?


Reply to this email directly or view it on GitHub (#238 (comment)).

Owner

mike-burns commented Jan 2, 2013

I still can't repro locally, but it seems that our Travis CI build is failing for the same reason: https://travis-ci.org/thoughtbot/clearance/jobs/3895549

Is the #sort needed?

Contributor

narath commented Jan 2, 2013

Yes, looks like exactly the same error - "uninitialized constant Integration (NameError)"

The sort is not necessary, just the extra require line is. I think the sort just makes the load order fixed as opposed to FS dependent

~Narath

On Wednesday, January 2, 2013 at 3:46 AM, Mike Burns wrote:

I still can't repro locally, but it seems that our Travis CI build is failing for the same reason: https://travis-ci.org/thoughtbot/clearance/jobs/3895549
Is the #sort needed?


Reply to this email directly or view it on GitHub (#238 (comment)).

Owner

mike-burns commented Jan 3, 2013

Merged with slight changes. Thanks for tracking this down, @narath !

@mike-burns mike-burns closed this Jan 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment