Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent_controller option to configuration #784

Closed
wants to merge 1 commit into from

Conversation

@mgrachev
Copy link

mgrachev commented Apr 10, 2018

Hi there!

We use clearance to authenticate admins in our application. For our purpose, we'll need to change the base class of Clearance::BaseController from ApplicationController to Admin::ApplicationController. Also, I saw the same issue #777.

So, I made the simple solution to this problem.

@@ -109,6 +114,10 @@ def user_model
@user_model ||= ::User
end

def parent_controller

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Apr 10, 2018

Lint/DuplicateMethods: Method Clearance::Configuration#parent_controller is defined at both lib/clearance/configuration.rb:96 and lib/clearance/configuration.rb:117.

spec/configuration_spec.rb Outdated Show resolved Hide resolved
spec/configuration_spec.rb Outdated Show resolved Hide resolved
@BerkhanBerkdemir

This comment has been minimized.

Copy link

BerkhanBerkdemir commented Sep 9, 2018

There is a few issue with this, this and this one. I think this PR needs a quick look for Rails 3.2. Also, the PR has written like a poet.

@mjankowski

This comment has been minimized.

Copy link
Member

mjankowski commented Nov 14, 2019

Rebased and merged in #867

@mjankowski mjankowski closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.