Skip to content

Allow cookie_domain to be a string or a callable - #851

Merged
mjankowski merged 2 commits into
thoughtbot:masterfrom
Rakefire:feature/dynamic-cookie-domain
Sep 16, 2019
Merged

Allow cookie_domain to be a string or a callable#851
mjankowski merged 2 commits into
thoughtbot:masterfrom
Rakefire:feature/dynamic-cookie-domain

Conversation

@rickychilcott

@rickychilcott rickychilcott commented Aug 20, 2019

Copy link
Copy Markdown
Contributor

This allows Clearance.configuration.cookie_domain to be a callable object or method to support special cookie_domain configurations

Close #786 and #563

Comment thread lib/clearance/session.rb Outdated
Comment thread spec/clearance/session_spec.rb
Comment thread spec/clearance/session_spec.rb Outdated
Comment thread spec/clearance/session_spec.rb Outdated
Comment thread spec/clearance/session_spec.rb Outdated
Comment thread spec/clearance/session_spec.rb
Comment thread spec/clearance/session_spec.rb Outdated
Comment thread spec/clearance/session_spec.rb Outdated
Comment thread spec/clearance/session_spec.rb Outdated
@rickychilcott
rickychilcott force-pushed the feature/dynamic-cookie-domain branch from 0df09ac to 1dece3e Compare August 20, 2019 15:59
@mjankowski
mjankowski merged commit c736f3d into thoughtbot:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Allow config.cookie_domain to be a lambda

2 participants