Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Remove official support for REE

  • Loading branch information...
commit 6073cd07b8d470d93d402dacda4e82c9cd195d75 1 parent 69d6b6c
@jyurek jyurek authored
View
1  .travis.yml
@@ -2,5 +2,4 @@ rvm:
- 1.8.7
- 1.9.2
- 1.9.3
- - ree
- jruby
View
13 README.md
@@ -149,6 +149,19 @@ in https://github.com/thoughtbot/cocaine/issues/24 and probably fixed in
http://jira.codehaus.org/browse/JRUBY-6162. You *will* want to use the
`BackticksRunner` if you are unable to update JRuby.
+## REE
+
+So, here's the thing about REE: The specs that involve timeouts don't work
+there. Not because the logic is unsound, but because the command runs really
+slowly. The test passes -- eventually. This was verified using an external
+debugger: the process that REE kicks off in the tests reads and writes
+surprisingly slowly. For this reason, we cannot recommend using Cocaine with
+REE anymore.
+
+It's not something we like, so if anyone has any insight into this problem,
+we'd love to hear about it. But, for the time being, we'll consider it more
+appropriate to just not use it anymore. Upgrade to 1.9.3, people.
+
## Feedback
*Security* concerns must be privately emailed to
View
1  cocaine.gemspec
@@ -21,5 +21,6 @@ Gem::Specification.new do |s|
s.add_development_dependency('mocha')
s.add_development_dependency('rake')
s.add_development_dependency('posix-spawn')
+ s.add_development_dependency('system_timer')
end
View
1  spec/spec_helper.rb
@@ -4,6 +4,7 @@
require 'cocaine'
require 'timeout'
require 'tempfile'
+require 'system_timer'
Dir[File.dirname(__FILE__) + "/support/**.rb"].each{|support_file| require support_file }
View
2  spec/support/nonblocking_examples.rb
@@ -3,7 +3,7 @@
garbage_file = Tempfile.new("garbage")
10.times{ garbage_file.write("A" * 1024 * 1024) }
- Timeout::timeout(5) do
+ SystemTimer.timeout_after(5) do
output = subject.call("cat '#{garbage_file.path}'")
$?.exitstatus.should == 0
output.length.should == 10 * 1024 * 1024
Please sign in to comment.
Something went wrong with that request. Please try again.