Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 23, 2015
  1. Radosław Bułat
Commits on Feb 6, 2015
  1. Jon Yurek

    Add a semicolon to the PATH definition

    jyurek authored
    So, this seems trivial, but according to #77, the previous behavior
    caused a problem with more complicated commands. Granted, it seems weird
    to call commands like `if [thing]; then true; else false; fi` but here
    we are. If I add the semicolon, then the shell treats it as a separate
    command. This means it modifies the shell env, but this is fine in the
    subshell environment we're running the command in. Normally, if you were
    running this on your command line, I wouldn't recommend it: as I said,
    this would modify your environment instead of modifying the command's
    environment. But we should be good here.
Commits on Dec 17, 2014
  1. Jon Yurek

    Merge pull request #75 from ktdreyer/gemfile-url-https

    jyurek authored
    Gemfile: use HTTPS for rubygems.org
  2. Jon Yurek

    Merge pull request #74 from ktdreyer/gemspec-url-https

    jyurek authored
    gemspec: use HTTPS for homepage URL
  3. Ken Dreyer

    Gemfile: use HTTPS for rubygems.org

    ktdreyer authored
    Use HTTPS so users' connections to the rubygems.org server will be
    verified with SSL.
  4. Ken Dreyer
Commits on Dec 16, 2014
  1. Jon Yurek

    Remove rbx from Travis for now

    jyurek authored
  2. Jon Yurek

    Add 2.1.5 and rbx to Travis

    jyurek authored
  3. Jon Yurek
Commits on Dec 9, 2014
  1. Jon Yurek

    v0.5.5

    jyurek authored
Commits on Dec 3, 2014
  1. Jon Yurek

    C'mon. Who uses REE anymore?

    jyurek authored
  2. Jon Yurek

    Don't use ClimateControl when it's not necessary

    jyurek authored
    The ProcessRunner and PosixRunner are perfectly capable of taking an
    environment hash. This means there's no reason to use ClimateControl to
    modify the environment beforehand. In order to find custom binaries, we
    can modify the PATH on the command line -- yes, for both Unix and
    Windows.
    
    Unix commandlines use the normal `PATH=/new/path:$PATH cmd` syntax.
    Windows uses `SET PATH=C:\new\path;%PATH% & cmd` instead.
    
    The difference between then and now is that I found out that you can
    actually separate commands in Windows with `&` (see
    http://support.microsoft.com/kb/279253).
    
    As a result of this the `supplemental_environment` isn't modified when
    the `path` is modified. We keep the path in memory as a
    `Cocaine::OS.path_separator`-separated string.
    
    In addition, this commit cleans up the OS detection slightly, moving it
    to a new class. In the future, we can do things like telling instead of
    asking.
    
    The result of all this is that the `ProcessRunner` and `PosixRunner`
    should be thread-safe, since we're not mucking around with the `ENV`
    when we run stuff anymore. This will make the high-throughput users of
    Paperclip happy, since they shouldn't see clobbering issues like they
    did before. I tested this by running the code supplied by @maxim,
    thoughtbot/paperclip#1709 (comment),
    with the unmodified cocaine 0.5.4 gem and with this commit in place. It
    failed in a few seconds before and ran for as long as I wanted after.
    
    This also might fix a bug? Previously, on Java on Windows, commands
    would be called prefixed with `env`, which doesn't exist on Windows. No
    one complained, though, so you can guess how popular Java on Windows is
    (or I'm completely screwing up).  Now we look for Windows first, then
    use `env` with Java, and then Unix like normal.
Commits on Jun 25, 2014
  1. Jeremy Neander
Commits on Jun 20, 2014
  1. Jeremy Neander

    Use '==' for assertions against true and false

    jneander authored
    This fixes tests breaking with non-monkey-patched 'true' and 'false' objects.
Commits on Jun 5, 2014
  1. Jon Yurek

    Merge pull request #69 from thoughtbot/gbw-test-against-latest-rubies

    jyurek authored
    Test against latest Rubies on Travis
  2. Jon Yurek

    Merge pull request #68 from thoughtbot/gbw-show-master-status

    jyurek authored
    Only show master branch Travis status in README
  3. Gabe Berke-Williams

    Remove unused allowed failure on Travis

    gabebw authored
    We were allowing `rbx-19mode` to fail, but not testing against it.
  4. Gabe Berke-Williams
  5. Gabe Berke-Williams

    Whitespace

    gabebw authored
  6. Gabe Berke-Williams
Commits on May 23, 2014
  1. Jon Yurek
  2. Jon Yurek
  3. Jon Yurek
  4. Jon Yurek
  5. Daniel Jabbour Jon Yurek

    Ensuring exit status is always set, even when $? isn't

    bitgangsta authored jyurek committed
Commits on Mar 28, 2014
  1. Jon Yurek

    v0.5.4

    jyurek authored
  2. Jon Yurek

    Runners find programs in the supplemental path

    jyurek authored
    Even though you can supply an environment to `Process.spawn` and
    `Posix.spawn`, that doesn't mean they'll use that environment while
    looking for executables. A modified PATH environment is passed correctly
    on to the spawned process, but an executable is not searched for in the
    modified PATH. Given that, we need to modify the environment when
    `spawn` is called. As `BackticksRunner` and `POpenRunner` both modified
    the environment already, they worked fine.
Commits on Jan 27, 2014
  1. Adarsh Pandit

    Update copyright to 2014

    adarsh authored
Commits on Jan 20, 2014
  1. Jon Yurek

    Merge pull request #62 from pasku/travis

    jyurek authored
    Add Ruby 2.1.0 to .travis.yml
Commits on Jan 14, 2014
  1. Guillermo Pascual

    Add Ruby 2.1.0 to .travis.yml

    pasku authored
Commits on Jan 8, 2014
  1. Guillermo Pascual

    Some refactors.

    pasku authored
Commits on Jan 2, 2014
  1. nifarius Jon Yurek

    Add options for each runner.

    nifarius authored jyurek committed
Commits on Nov 15, 2013
  1. Jon Yurek
  2. Skye Shaw

    interpolate Array arguments

    sshaw authored
Commits on Nov 8, 2013
  1. Jon Yurek

    Reorganize the specs a bit

    jyurek authored
Something went wrong with that request. Please try again.