Skip to content

Loading…

ANSI color codes should check for tty first #30

Closed
mperham opened this Issue · 1 comment

2 participants

@mperham

When using ANSI color codes, the correct thing to do is check if the output device is a tty? because stdout is often redirected to a file. For example:

logger = Logger.new(STDOUT)
logger.use_ansi = STDOUT.tty?

When I enable command logging through Paperclip, syslog fills up with this:

Oct 15 20:26:49 dt3 sidekiq[24443]: #033[32mCommand#033[0m :: file -b --mime :file
@jyurek
thoughtbot, inc. member

Quite right! I just pushed a fix in f986c81. Thanks for the report!

@jyurek jyurek closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.