Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) JRuby note very old #1395

Closed
olleolleolle opened this issue May 15, 2020 · 2 comments
Closed

(docs) JRuby note very old #1395

olleolleolle opened this issue May 15, 2020 · 2 comments
Labels
bug documentation good first issue

Comments

@olleolleolle
Copy link

Description

This section on JRuby mentions very old JRuby things.

https://github.com/thoughtbot/factory_bot/blob/master/GETTING_STARTED.md#jruby

Reproduction Steps

Expected behavior

I expect JRuby not be mentioned specially at all.

Actual behavior

We have this old note.

System configuration

factory_bot version: master
rails version:
ruby version:
@composerinteralia
Copy link
Collaborator

Thanks! Yup, we should definitely remove that.

@volfgox
Copy link
Contributor

volfgox commented May 19, 2020

You mean JRuby things in that document is no longer needed and should be removed?

volfgox added a commit to volfgox/factory_bot that referenced this issue May 19, 2020
@volfgox
[Fix thoughtbot#1395] Remove JRuby things
731d659 
JRuby section in GETTING_STARTED.md file was very old. So, it was
removed.
@volfgox volfgox mentioned this issue May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olleolleolle @volfgox @composerinteralia