Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRename of FactoryGirl to FactoryBot has broken my projects #243
Comments
iHiD
changed the title from
Rename of FactoryGirl to FactoryBot has broken everything
to
Rename of FactoryGirl to FactoryBot has broken my projects
Oct 21, 2017
iHiD
referenced this issue
Oct 21, 2017
Closed
Rename of FactoryGirl to FactoryBot has broken my projects #1055
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Euraldius
Oct 21, 2017
Contributor
Cross posting from the factory_bot issue thoughtbot/factory_bot#1055 (comment)
Hey! Sorry for the trouble this is causing; we didn't expect it to be a breaking change. The intended behavior is that you see a deprecation warning when you run the test suite. We're investigating now.
|
Cross posting from the factory_bot issue thoughtbot/factory_bot#1055 (comment)
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mjankowski
Oct 24, 2017
Member
We apologize for the breakage we caused by fumbling the initial gem release.
Here's a blog post with a full explanation and upgrade instructions - https://robots.thoughtbot.com/factory_bot
FG 4.9.0 should be just a deprecation warning now, and getting FB will require a proactive upgrade initiated by developer.
|
We apologize for the breakage we caused by fumbling the initial gem release. Here's a blog post with a full explanation and upgrade instructions - https://robots.thoughtbot.com/factory_bot FG 4.9.0 should be just a deprecation warning now, and getting FB will require a proactive upgrade initiated by developer. |
iHiD commentedOct 21, 2017
Hello. Sorry for the slightly dramatic issue title, but I couldn't find a gentler way to say it :)
Running bundle update and running tests now gives:
NameError: uninitialized constant ActionView::TestCase::FactoryGirlRenaming
FactoryGirltoFactoryBoteverywhere in my code fixes the issue, but I think such a breaking change should result in a Major version increment, not a Patch increment. I would suggest reverting the 4.8 branch to factory_girl and release 5.0 as factory_bot.