New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename of FactoryGirl to FactoryBot has broken my projects #243

Closed
iHiD opened this Issue Oct 21, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@iHiD

iHiD commented Oct 21, 2017

Hello. Sorry for the slightly dramatic issue title, but I couldn't find a gentler way to say it :)

Running bundle update and running tests now gives:
NameError: uninitialized constant ActionView::TestCase::FactoryGirl

Renaming FactoryGirl to FactoryBot everywhere in my code fixes the issue, but I think such a breaking change should result in a Major version increment, not a Patch increment. I would suggest reverting the 4.8 branch to factory_girl and release 5.0 as factory_bot.

@iHiD iHiD changed the title from Rename of FactoryGirl to FactoryBot has broken everything to Rename of FactoryGirl to FactoryBot has broken my projects Oct 21, 2017

@Euraldius

This comment has been minimized.

Show comment
Hide comment
@Euraldius

Euraldius Oct 21, 2017

Contributor

Cross posting from the factory_bot issue thoughtbot/factory_bot#1055 (comment)

Hey! Sorry for the trouble this is causing; we didn't expect it to be a breaking change. The intended behavior is that you see a deprecation warning when you run the test suite. We're investigating now.

Contributor

Euraldius commented Oct 21, 2017

Cross posting from the factory_bot issue thoughtbot/factory_bot#1055 (comment)

Hey! Sorry for the trouble this is causing; we didn't expect it to be a breaking change. The intended behavior is that you see a deprecation warning when you run the test suite. We're investigating now.

@mjankowski

This comment has been minimized.

Show comment
Hide comment
@mjankowski

mjankowski Oct 24, 2017

Member

We apologize for the breakage we caused by fumbling the initial gem release.

Here's a blog post with a full explanation and upgrade instructions - https://robots.thoughtbot.com/factory_bot

FG 4.9.0 should be just a deprecation warning now, and getting FB will require a proactive upgrade initiated by developer.

Member

mjankowski commented Oct 24, 2017

We apologize for the breakage we caused by fumbling the initial gem release.

Here's a blog post with a full explanation and upgrade instructions - https://robots.thoughtbot.com/factory_bot

FG 4.9.0 should be just a deprecation warning now, and getting FB will require a proactive upgrade initiated by developer.

@mjankowski mjankowski closed this Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment