Please sign in to comment.
Overrides become methods defined on each instance of the evaluator
There were some big issues with trying to undefine specific methods on the Evaluator. After investigating maybe inheriting from BasicObject (or ActiveSupport::BasicObject since BasicObject is 1.9+), that turned out to be too much of a pain because it undefines almost everything, including class and a handful of other methods necessary for Evaluator to work properly. The second solution was to undefine all private methods. The problem is, when other libraries defining methods (private or otherwise) on Object are loaded *after* factory girl, those methods get added and Evaluator sees those methods on Object. So, that solution didn't work either. This commit removes undefining methods (the sole reason of which was to capture with method_missing and process ourselves, returning the override or cached value) and instead introduces a new concept - iterating over each override and defining it as a method on the evaluator INSTANCE. This means that overrides don't collide because they're on the instance and we don't have to worry about undefining methods so that method_missing kicks in. Although not nececessarily as performant, this is the most stable and guaranteed way to get this to work, because the overrides are applied to each instance at runtime. Closes #279, #285 (again)
- Loading branch information...
Showing with 24 additions and 14 deletions.