This repository has been archived by the owner. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually moved in to gemspec in commit ea096a3 Could probably group them in to a separate environment
Hi Gareth, I see you added a Rakefile, but I couldn't get rake to run:
When I tried running the specs I got this error:
|
I've made the tests work now (wooo!). I'm not actually sure whether I need the Rakefile. I added it in as it lets you do |
1 similar comment
I've made the tests work now (wooo!). I'm not actually sure whether I need the Rakefile. I added it in as it lets you do |
The Rakefile still doesn't work but the specs pass. Removing the Rakefile for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was having some trouble using FistFace with other Sinatra extensions, so as a first step I made it in to a 'modular' extension style. Its also inline with the Sinatra "Rules for Extensions" http://www.sinatrarb.com/extensions.html#rules_for_extensions