This repository has been archived by the owner. It is now read-only.

Change to Modular Extension #2

Merged
merged 8 commits into from Jul 18, 2011

Conversation

Projects
None yet
2 participants
@garethrees
Contributor

garethrees commented Jul 18, 2011

I was having some trouble using FistFace with other Sinatra extensions, so as a first step I made it in to a 'modular' extension style. Its also inline with the Sinatra "Rules for Extensions" http://www.sinatrarb.com/extensions.html#rules_for_extensions

@mike-burns

This comment has been minimized.

Show comment
Hide comment
@mike-burns

mike-burns Jul 18, 2011

Member

Hi Gareth,

I see you added a Rakefile, but I couldn't get rake to run:

~/lib/fistface% bundle exec rake
/var/lib/gems/1.8/gems/bundler-1.0.12/lib/bundler/shared_helpers.rb:107:in `gem': rake is not part of the bundle. Add it to Gemfile. (Gem::LoadError)
    from /var/lib/gems/1.8/bin/rake:18

When I tried running the specs I got this error:

~/lib/fistface% bundle exec rspec spec 
/var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/backward_compatibility.rb:20:in `const_missing': uninitialized constant FistFace (NameError)
    from /home/mike/lib/fistface/spec/fistface_spec.rb:3
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load_spec_files'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `map'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load_spec_files'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/command_line.rb:18:in `run'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:55:in `run_in_process'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:46:in `run'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:10:in `autorun'
    from /var/lib/gems/1.8/bin/rspec:19
Member

mike-burns commented Jul 18, 2011

Hi Gareth,

I see you added a Rakefile, but I couldn't get rake to run:

~/lib/fistface% bundle exec rake
/var/lib/gems/1.8/gems/bundler-1.0.12/lib/bundler/shared_helpers.rb:107:in `gem': rake is not part of the bundle. Add it to Gemfile. (Gem::LoadError)
    from /var/lib/gems/1.8/bin/rake:18

When I tried running the specs I got this error:

~/lib/fistface% bundle exec rspec spec 
/var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/backward_compatibility.rb:20:in `const_missing': uninitialized constant FistFace (NameError)
    from /home/mike/lib/fistface/spec/fistface_spec.rb:3
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load_spec_files'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `map'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/configuration.rb:387:in `load_spec_files'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/command_line.rb:18:in `run'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:55:in `run_in_process'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:46:in `run'
    from /var/lib/gems/1.8/gems/rspec-core-2.4.0/lib/rspec/core/runner.rb:10:in `autorun'
    from /var/lib/gems/1.8/bin/rspec:19
@garethrees

This comment has been minimized.

Show comment
Hide comment
@garethrees

garethrees Jul 18, 2011

Contributor

I've made the tests work now (wooo!).

I'm not actually sure whether I need the Rakefile. I added it in as it lets you do rake install to install the gem locally. Should I just get rid of it?

Contributor

garethrees commented Jul 18, 2011

I've made the tests work now (wooo!).

I'm not actually sure whether I need the Rakefile. I added it in as it lets you do rake install to install the gem locally. Should I just get rid of it?

@garethrees

This comment has been minimized.

Show comment
Hide comment
@garethrees

garethrees Jul 18, 2011

Contributor

I've made the tests work now (wooo!).

I'm not actually sure whether I need the Rakefile. I added it in as it lets you do rake install to install the gem locally. Should I just get rid of it?

Contributor

garethrees commented Jul 18, 2011

I've made the tests work now (wooo!).

I'm not actually sure whether I need the Rakefile. I added it in as it lets you do rake install to install the gem locally. Should I just get rid of it?

@garethrees garethrees closed this Jul 18, 2011

@garethrees garethrees reopened this Jul 18, 2011

@mike-burns

This comment has been minimized.

Show comment
Hide comment
@mike-burns

mike-burns Jul 18, 2011

Member

The Rakefile still doesn't work but the specs pass. Removing the Rakefile for now.

Member

mike-burns commented Jul 18, 2011

The Rakefile still doesn't work but the specs pass. Removing the Rakefile for now.

@mike-burns mike-burns merged commit afcb413 into thoughtbot:master Jul 18, 2011

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.