Skip to content

Loading…

/public/stylesheets/framework #2

Closed
croaky opened this Issue · 6 comments

4 participants

@croaky
thoughtbot, inc. member

I think we should use a /framework directory for anything Flutie generates.

Allows us to use the project more like an engine or like Suspenders.

The idea is: don't edit anything in /framework. Any modifications should be in in addition to the framework.

@croaky
thoughtbot, inc. member

If I get some +1s, I will make this change.

@thoughtbot

We're already doing this, basically - it installs things into public/flutie/stylesheets

(Matt)

@croaky
thoughtbot, inc. member

Are we sure? It looks like in training_app, it put them directly in public/stylesheets.

public/flutie/stylesheets is okay. I think I'd prefer public/stylesheets/flutie (or /framework, so other CSS frameworks can latch on to the same convention and the community can feel better about switching one in for another).

@mjankowski
thoughtbot, inc. member

I put it in training_app before Chad committed the engine stuff. Lunchapp I think is the only thing currently with the engine installation.

@cpytel
thoughtbot, inc. member

I went with public/flutie/stylesheets to allow for public/flutie/otherstuff in the future. Like public/flutie/images and public/flutie/javascripts so that everything is under a single root.

@croaky
thoughtbot, inc. member

Cool. This was my confusion based on flutie being in training_app before it was engine-ized and had some of this stuff. public/flutie makes sense. Closing this issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.