Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
success, failure, notice flash messages #3
Suspenders outputs divs with specific ids.
Right now Flutie styles on classes that will need to be added (div.error, div.notice, div.success).
I propose we style similar to the following:
I also propose we stick to success, failure, and notice as the three flashes. This is what we've been teaching to students at training. It is also the standard that Clearance uses.
Same goes for fieldWithErrors and errorExplanation. We don't have anything in there yet.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I agree on having the flash naming and provided styles be consistent with the generator of flash output we use in suspenders.
I think there's a reason we should use classes and not ids for this, though - but I need to find the spot where this occurred to me to remember why.
I think the formtastic style error field styling IS in flutie, but the generic rails fieldWithErrors style is not.
Formtastic styles are in flutie. One thing I noticed about those in comparison to the styles in the formtastic_stylesheets generator was that we're not namespacing by .formtastic. Do we care? What's our general philosophy on how much 'namespacing' we should do? If I remember correctly, Angelo was very big on that but I think in one of our discussions about these stylesheets standards, the point was made that we want wider flexibility?