Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Asset pipeline 2 #25

Merged
merged 5 commits into from Jul 5, 2011

Conversation

Projects
None yet
3 participants
Contributor

sakuro commented Jul 1, 2011

Recreated asset pipiline patch that uses app/assets instead of vendor/assets.

I'll close older pull req and issues.

Owner

mjankowski commented Jul 1, 2011

This looks good. On the copy task though, I don't think we need the :assets capability check. I think we can update the readme to reflect that...

  • If you are on rails 3.1 and using the asset pipeline, you don't need to run the rake task or copy any files
  • If you are on a prior version, or on 3.1 and not using the pipeline and/or not using sass, you do need to run the rake task

This way we don't exclude people who are on 3.1 (and thus will return true on the :assets check) but who don't actually want to use the pipeline.

Contributor

sakuro commented Jul 2, 2011

I am neutral about conditionally guarding copy or not.

croaky added a commit that referenced this pull request Jul 4, 2011

Merge pull request #25 from sakuro/asset-pipeline-2
asset pipeline patch that uses app/assets instead of vendor/assets

@croaky croaky merged commit 8590953 into thoughtbot:master Jul 5, 2011

Contributor

croaky commented Jul 5, 2011

Merged this in. I personally like that conditional guard + friendly standard out message but feel free to remove it if you want, Matt.

Owner

mjankowski commented Jul 5, 2011

Yeah, that's fine as-is. In retrospect, I don't actually care about the "using rails 3.1 but NOT the asset pipeline" use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment